Ticket #6661 (closed defect (bug): fixed)

Opened 9 months ago

Last modified 9 months ago

IE6 overlap renders uploader media library unusable

Reported by: tellyworth Assigned to: anonymous
Priority: normal Milestone: 2.5.1
Component: General Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

The toggle sliders on the media library tab of the media uploader overlap and render the UI unusable.

Screenshot attached.

Attachments

ie6-overlap.gif (37.7 kB) - added by tellyworth on 04/10/08 11:30:27.
media-library-ie6-overlap-r7638.patch (1.0 kB) - added by tellyworth on 04/10/08 11:35:30.
media-library-ie6-overlap-r7641-2.patch (5.1 kB) - added by tellyworth on 04/14/08 01:23:17.
Fix the progress bar, remove some unnecessary markup

Change History

04/10/08 11:30:27 changed by tellyworth

  • attachment ie6-overlap.gif added.

04/10/08 11:35:30 changed by tellyworth

  • attachment media-library-ie6-overlap-r7638.patch added.

04/10/08 11:36:26 changed by tellyworth

The problem seems to stem from the use of relative and absolute positioning within the tables - it affects the height of containers in unexpected ways, especially with buggy browsers.

I was unable to come up with a fix that retained the same positioning methods, but switching to floats and divs in the regular document flow fixed the problem. The enclosed patch fixes it, works properly and looks acceptable in all the browsers I've tested (IE6, Opera/win, Safari and FF on OS/X). The only known issue with it is that the clickmask that made the entire row clickable is gone. I don't consider that a major drawback because I have some unconfirmed reports that the clickmask interferes with the UI in some browsers.

04/10/08 11:36:41 changed by tellyworth

  • keywords set to has-patch.

04/10/08 12:08:51 changed by tellyworth

argh, the progress bar winds up in the wrong place and makes other things unclickable.

04/10/08 23:32:08 changed by tellyworth

Turned up another bug trying to fix this: prepareMediaItem() in handlers.js creates duplicate progress clickmask divs. There are two progress clickmasks in each item in the gallery tab, three in each item in the media library tab.

04/14/08 01:23:17 changed by tellyworth

  • attachment media-library-ie6-overlap-r7641-2.patch added.

Fix the progress bar, remove some unnecessary markup

04/14/08 01:29:12 changed by tellyworth

The new patch works well in IE6, Safari 3.1 and Firefox 2. The overlap issue in IE6 is fixed. Progress bars display in all three browsers. I haven't yet tested Opera.

There are some visual differences with 2.5.0 but I think they are acceptable. The clickmask is gone (but as noted above, I don't think that's a major issue - it caused some compatibility issues and didn't work on the Gallery or Choose File tabs). The markup and CSS is slightly simpler, and the duplicate progress divs have been removed If anyone can improve on it, please do.

04/14/08 20:47:51 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7676]) Fix IE6 overlap and remove unnecessary markup. Props tellyworth. fixes #6661 for 2.5

04/14/08 20:48:11 changed by ryan

(In [7677]) Fix IE6 overlap and remove unnecessary markup. Props tellyworth. fixes #6661 for trunk