Ticket #6731 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

edit-pages.php does not correctly order pages by menu_order

Reported by: torfason Assigned to: anonymous
Priority: normal Milestone: 2.5.1
Component: Administration Version: 2.5
Severity: normal Keywords: edit-pages.php query.php
Cc:

Description

In version 2.5, as well as in the most recent checkout, the list of pages generated by edit-pages.php does not correctly order pages by the menu_order column. The reason is the lack of a break statement in query.php, which causes the menu_order case to fall through to the next case and the $orderby variable gets set to $wpdb->posts.ID.

A patch detailing an insertion of this break statement is attached, which seems to fix the problem.

Attachments

query-php-break-statement.diff (339 bytes) - added by torfason on 04/15/08 00:26:39.
Patch to fix the bug, by inserting a break into the statement

Change History

04/15/08 00:26:39 changed by torfason

  • attachment query-php-break-statement.diff added.

Patch to fix the bug, by inserting a break into the statement

04/15/08 01:39:20 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7684]) Fix menu_order ordering. Props torfason. fixes #6731 for 2.5

04/15/08 01:39:34 changed by ryan

(In [7685]) Fix menu_order ordering. Props torfason. fixes #6731 for trunk

04/15/08 01:44:36 changed by Viper007Bond

Dupe of #6587 but since this one got the fix, I'll close the other one.

04/15/08 01:44:54 changed by Viper007Bond

  • version set to 2.5.
  • milestone changed from 2.7 to 2.5.1.