Ticket #6811 (closed enhancement: fixed)

Opened 7 months ago

Last modified 3 months ago

Unify TinyMCE image popup and insert image popup

Reported by: matt Assigned to: azaozz
Priority: normal Milestone: 2.6.1
Component: Administration Version: 2.5
Severity: normal Keywords: blessed
Cc:

Description

Right now we have two methods for interacting with images, one bundled with TinyMCE and one from our "insert image" dialog.

Our insert image dialog has some better functionality around alignment and such, so we should standardize on that.

Attachments

wpeditimage.zip (14.6 kB) - added by azaozz on 06/09/08 05:32:37.
edit-image-popup.patch (6.3 kB) - added by azaozz on 06/09/08 06:31:04.
edit-image-popup2.patch (32.4 kB) - added by azaozz on 06/14/08 10:05:46.
editimage-rtl.zip (455 bytes) - added by azaozz on 06/14/08 20:55:49.
edit-image-popup3.patch (25.2 kB) - added by azaozz on 06/23/08 12:00:30.
edit-image-popup4.patch (9.2 kB) - added by azaozz on 06/25/08 15:56:19.

Change History

04/22/08 23:52:21 changed by matt

See also: #6812.

06/09/08 05:32:37 changed by azaozz

  • attachment wpeditimage.zip added.

06/09/08 05:42:13 changed by azaozz

Customized Edit Image dialog, first run. Has the functionality of both "Insert/Edit Image" and "Insert/Edit Link" popups in TinyMCE, together with several WordPress specific features (css classes, attachment rel, etc.). Also the look and feel is like the Add Media dialog.

Has an advanced tab that may need some options added or removed.

The zip file contains a TinyMCE plugin that goes to /wp-includes/js/tinymce/plugins/.

06/09/08 06:31:04 changed by azaozz

  • attachment edit-image-popup.patch added.

06/10/08 04:40:22 changed by ryan

(In [8066]) Unify TinyMCE image popup and insert image popup. Props azaozz. see #6811

(follow-up: ↓ 5 ) 06/10/08 04:40:46 changed by ryan

I think some strings in the plugin need to be setup for translation.

(in reply to: ↑ 4 ) 06/10/08 05:30:06 changed by azaozz

Replying to ryan:

I think some strings in the plugin need to be setup for translation.

Yes, the translation strings aren't in yet. Was wondering if this should be integrated with the "Add external image" too.

06/14/08 09:29:03 changed by azaozz

Second run. Added translation strings, RTL support, several layout improvements, image border, hspace and vspace can be used as shortcuts to add css styles, the preview is visible on both tabs, etc.

Also made a small change to ThickBox?' style for the loading animation, now it's shown in a box similarly to the theme preview on http://wordpress.com.

06/14/08 10:05:46 changed by azaozz

  • attachment edit-image-popup2.patch added.

06/14/08 16:38:08 changed by ryan

(In [8083]) Image popup improvements from azaozz. Added translation strings, RTL support, several layout improvements, image border, hspace and vspace can be used as shortcuts to add css styles, the preview is visible on both tabs, etc. see #6811

06/14/08 20:55:36 changed by azaozz

The edit-image-popup2.patch includes a new file: wp-includes/js/tinymce/plugins/wpeditimage/css/editimage-rtl.css that didn't get created for some reason. Adding a zipped version of it.

06/14/08 20:55:49 changed by azaozz

  • attachment editimage-rtl.zip added.

06/14/08 21:02:05 changed by ryan

[8088]

06/23/08 12:00:17 changed by azaozz

Fixes: align center in IE, import of color css stylesheets, potential error on submit when removing align center, few css fixes, etc. The image size setting is now on the side and is in percents of the current size.

06/23/08 12:00:30 changed by azaozz

  • attachment edit-image-popup3.patch added.

06/23/08 15:26:03 changed by ryan

(In [8167]) Edit image updates from azaozz. see #6811

06/25/08 08:47:53 changed by azaozz

Several fixes: new link not created if the image has class "aligncenter" in Safari; recalculates the demo image size properly and applies any inline styles to it; if relative link is added, it's converted to absolute; "Unknown error" in IE6, although everything is working well.

06/25/08 15:56:19 changed by azaozz

  • attachment edit-image-popup4.patch added.

06/25/08 16:30:28 changed by ryan

(In [8191]) Edit image fixes from azaozz: : new link not created if the image has class "aligncenter" in Safari; recalculates the demo image size properly and applies any inline styles to it; if relative link is added, it's converted to absolute; "Unknown error" in IE6. see #6811

08/11/08 06:02:24 changed by azaozz

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 2.9 to 2.6.1.

Done.