Ticket #6813 (closed enhancement: fixed)

Opened 5 months ago

Last modified 2 months ago

Press This bookmarklet - quick posting from around the web

Reported by: matt Assigned to: ryan
Priority: high Milestone: 2.6
Component: Administration Version: 2.5
Severity: normal Keywords: blessed
Cc:

Description

We've had a bookmarklet since WordPress 1.0, it used to be a popup, then we had a sidebar thing, then a redirect to the standard post interface. I think there are some really good examples of a nice quick post interaction that doesn't bounce you off the page. There's a good plugin already:

http://web.twelvehorses.com/projects/quickpost/

If you know of any other examples add them as comments.

Attachments

quick-post.diff (26.0 kB) - added by ryan on 05/10/08 18:41:19.
tab.png (0.7 kB) - added by ryan on 05/10/08 18:45:58.
quick-post-mce.patch (5.3 kB) - added by azaozz on 05/13/08 09:37:18.
press-this-noel-6-16-08.diff (7.9 kB) - added by noel on 06/16/08 21:39:41.
June 16 5:39pm
loading-publish.gif (1.8 kB) - added by noel on 06/16/08 21:40:35.
wp-admin/images/ is the correct path for this file.
press-this-6-18-08-5am.diff (9.6 kB) - added by noel on 06/18/08 09:10:20.
Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.
press-this-6-18-08-3pm.diff (9.5 kB) - added by noel on 06/18/08 19:33:09.
(merge arrows fixed) Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.
press-this-6-19-9pm.diff (1.1 kB) - added by noel on 06/20/08 01:28:29.
press this photo tab fixes.
media-6-23-1am.diff (2.2 kB) - added by noel on 06/23/08 05:50:19.
Press this fixes for media.php dealing with wp_error object
press-this-6-23-1am.diff (2.5 kB) - added by noel on 06/23/08 05:51:44.
Fixes corresponding with wp_error object issues - this negates the was patched from rev 8166 (negates 6-19 patch)
press-this-6-23-4am.diff (18.4 kB) - added by noel on 06/23/08 07:58:36.
This patch fixes problems with wp_error the photo tab and some js issues dealing with cross-browser implementation.
press-this-fixes-hotlinking-6-23-5pm.diff (2.9 kB) - added by noel on 06/23/08 20:58:37.
High Priority! Fixes image uploading hotlinking issue.
press-this-sideload-querystringfix.diff (0.6 kB) - added by noel on 06/25/08 08:00:30.
Query String fix for file.php
press-this-media-handling-6-26.diff (357 bytes) - added by noel on 06/26/08 22:01:19.
Fix for image uploader that was adding http:// for no reason.
press-this-7-2-4am.diff (458 bytes) - added by noel on 07/02/08 08:00:10.
Escape quotes in titles.
press-this_0704.patch (4.3 kB) - added by azaozz on 07/04/08 15:52:39.
press-this_7-9-5pm.diff (16.0 kB) - added by noel on 07/09/08 21:25:09.
CSS cleanup, photo input newline breaks, fixes short_tags problem
press-this_7-10-9pm.diff (0.8 kB) - added by noel on 07/11/08 00:54:10.
Fixes continuous linking issue by using rlm entity;
press-this-ie.css (96 bytes) - added by noel on 07/11/08 04:22:50.
wp-admin/css/ IE stylesheet
press-this_7-11-1am.diff (1.2 kB) - added by noel on 07/11/08 04:31:25.
IE CSS stylesheet conditional comment
pess-this-selection-fix.patch (17.7 kB) - added by azaozz on 07/11/08 11:13:27.
Fixes inserting the selection in the editor and stripping of paragraphs when saving.
press-this-combined_7-11.patch (20.3 kB) - added by noel on 07/11/08 19:46:20.
Combined patches from azaozz and noel.
pess-this-content-fix.patch (2.2 kB) - added by azaozz on 07/11/08 23:17:14.
press-this-20080712.patch (3.2 kB) - added by azaozz on 07/13/08 04:20:48.
press-this-ie.2.css (113 bytes) - added by azaozz on 07/13/08 04:21:40.
press-this_7-14.patch (0.5 kB) - added by noel on 07/14/08 17:56:32.
Fixes issue with Flickr and some other url variations

Change History

05/06/08 20:25:04 changed by ryan

http://ma.tt/2008/05/favorite-posting-bookmarklet/

05/10/08 18:41:19 changed by ryan

  • attachment quick-post.diff added.

05/10/08 18:45:24 changed by ryan

Patch uses the QuickPost? plugin as a base. Ported it to latest ui.tabs, added gettext, switched to use script loader and wp_category_checklist(), and changed to WP code formatting. It still needs some love, but this is a good start. The shortcut link is in the postbox on the Write->Post page.

05/10/08 18:45:58 changed by ryan

  • attachment tab.png added.

05/12/08 19:08:40 changed by ryan

(In [7919]) Quick post bookmarklet. First cut. see #6813

05/13/08 09:37:18 changed by azaozz

  • attachment quick-post-mce.patch added.

05/13/08 09:45:19 changed by azaozz

Some fixes for TinyMCE: added the new theme, languages, support for Safari, modal dialogs, changed some settings to be the same like the write page, small css fixes, etc.

05/13/08 15:22:53 changed by ryan

(In [7923]) Quick post TMCE improvements: add new theme, languages, support for Safari, modal dialogs, changed some settings to be the same like the write page, small css fixes. Props azaozz. see #6813

05/13/08 16:02:12 changed by ryan

(In [7924]) Quick post updates: More gettext, escaping, compress bookmarklet JS. see #6813

05/13/08 22:12:53 changed by ryan

(In [7927]) Don't pass image list via GET. Fetch images remotely. Load photo tab via AJAX. see #6813

05/13/08 22:17:55 changed by ryan

[7928]

05/14/08 16:59:08 changed by ryan

(In [7931]) Brand as Press This. see #6813

05/14/08 23:21:28 changed by ryan

(In [7933]) Only img src. see #6813

05/15/08 00:20:27 changed by ryan

(In [7934]) Press This: Fetch offsite images, fix slashing. see #6813

05/16/08 23:20:57 changed by ryan

(In [7945]) Some escaping. see #6813

06/11/08 17:37:56 changed by ryan

see #6998, #7025, #7026, #7049, #7066, #7117, #7120

06/11/08 17:38:58 changed by ryan

  • summary changed from Viva la bookmarklet - quick posting from around the web to Press This bookmarklet - quick posting from around the web.

06/11/08 17:41:13 changed by ryan

#7120 rearranges UI to put tags on the right. I'm not too crazy about that. I think we need to go through each tab and make some UI decisions.

06/11/08 17:45:50 changed by ryan

(In [8071]) Press This UI changes and photo loading fixes from noel. fixes #7120 see #6813

06/15/08 18:05:02 changed by ryan

(In [8093]) Press this updates from noel. see #6813

06/15/08 18:05:19 changed by ryan

see #7126

06/16/08 21:39:00 changed by noel

  • owner changed from matt to ryan.

Updates are now going in this ticket.

The latest patch fixes problems with paragraphs being transmitted through instead of just line breaks.

I've also attached the loading-publish.gif.

There is still a problem displaying apostrophes despite coming through clean. (?)

Example. Select "it's" in a webpage, click Press This, you'll now get "it\'s". Publish that post and you'll then get "it's" as you should. Anyone? Bueller?

06/16/08 21:39:41 changed by noel

  • attachment press-this-noel-6-16-08.diff added.

June 16 5:39pm

06/16/08 21:40:35 changed by noel

  • attachment loading-publish.gif added.

wp-admin/images/ is the correct path for this file.

06/17/08 19:36:30 changed by ryan

(In [8113]) Press This changes from noel. see #6813

06/17/08 19:41:37 changed by ryan

Looks like selection doesn't get the stripslashes() treatment. js_escape() strips and readds the slashes. I'm not sure we need js_escape() there. It's meant more for js included in onclicks and other attributes.

06/18/08 02:25:53 changed by noel

I talked with Andrew and seem to have it all figured out now. Another patch to fix the apostrophe/encoding oddities is coming soon.

06/18/08 09:10:20 changed by noel

  • attachment press-this-6-18-08-5am.diff added.

Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.

06/18/08 09:12:10 changed by noel

The latest attachment should be a big help. No more problems with Japanese/Hebrew or apostrophe issues. *crosses fingers*

The photo tab also got a nice upgrade to add a photo by URL and resizing the content area for the new photos added (this may need some more testing, but seems well enough for use in popular browsers).

06/18/08 18:21:30 changed by ryan

Looks like some merge arrows snuck into the css.

06/18/08 19:33:09 changed by noel

  • attachment press-this-6-18-08-3pm.diff added.

(merge arrows fixed) Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.

06/18/08 19:34:22 changed by noel

Sorry for being forgetting the merge arrows Ryan! All fixed.

06/18/08 19:35:21 changed by noel

And for misunderstanding the english language in my last reply ;)

06/19/08 17:03:24 changed by ryan

(In [8128]) Press This: Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab. Props noel. see #6813

06/20/08 01:28:29 changed by noel

  • attachment press-this-6-19-9pm.diff added.

press this photo tab fixes.

06/23/08 04:45:03 changed by noel

  • priority changed from normal to high.

06/23/08 05:50:19 changed by noel

  • attachment media-6-23-1am.diff added.

Press this fixes for media.php dealing with wp_error object

06/23/08 05:51:44 changed by noel

  • attachment press-this-6-23-1am.diff added.

Fixes corresponding with wp_error object issues - this negates the was patched from rev 8166 (negates 6-19 patch)

06/23/08 07:58:36 changed by noel

  • attachment press-this-6-23-4am.diff added.

This patch fixes problems with wp_error the photo tab and some js issues dealing with cross-browser implementation.

06/23/08 08:00:25 changed by noel

press-this-6-23-4am.diff should be the patch used.

Ignore press-this-6-23-1am.diff, media-6-23-1am.diff, and press-this-6-19-9pm.diff (if not already applied) since the latest patch contains all of those changes (since I diffed against trunk).

06/23/08 16:00:12 changed by ryan

(In [8169]) Press This updates from noel. see #6813

06/23/08 20:09:04 changed by noel

Photo tab has begun hotlinking. I'm working on clarifying this issue and getting a patch out asap.

06/23/08 20:58:37 changed by noel

  • attachment press-this-fixes-hotlinking-6-23-5pm.diff added.

High Priority! Fixes image uploading hotlinking issue.

06/23/08 20:58:57 changed by noel

Patch attached that fixes hotlinking issues.

06/23/08 21:16:40 changed by ryan

(In [8172]) Press This image linking fixes from noel. see #6813

06/25/08 08:00:12 changed by noel

Press This was having problems with sideloading images with query strings. A simple fix is attached.

06/25/08 08:00:30 changed by noel

  • attachment press-this-sideload-querystringfix.diff added.

Query String fix for file.php

06/25/08 16:45:04 changed by ryan

(In [8192]) Image sideloader fix from noel. see #6813

06/26/08 22:01:19 changed by noel

  • attachment press-this-media-handling-6-26.diff added.

Fix for image uploader that was adding http:// for no reason.

06/26/08 22:05:02 changed by ryan

(In [8201]) Don't prepend http. Props noel. see #6813

07/02/08 08:00:10 changed by noel

  • attachment press-this-7-2-4am.diff added.

Escape quotes in titles.

07/04/08 15:52:22 changed by azaozz

Was thinking to change TinyMCE to be compressed when loaded in Press This, but since it only loads 3 js files, it's faster to cache them with Gears instead.

The patch also includes few small css fixes:

  • Removed width="475" from the image preview in ThickBox?. Small images look quite bad with it. If scaling-down is needed, the images can be resized with 2 lines of js.
  • Changed the "Insert Image" and "Cancel" links to look more consistent.

While testing, Press This seems to have some problems:

  • If there is a selection on the page, all of it is inserted as a link in the editor.
  • If the selection is across two paragraphs, the encoding of the string seems wrong and breaks the editor.
  • The popup doesn't open in IE6 and opens in the main window in IE7 if the site doesn't have permission to show popups.
  • The layout is broken in IE7. May need to make/load specific css for IE.

07/04/08 15:52:39 changed by azaozz

  • attachment press-this_0704.patch added.

07/04/08 16:12:37 changed by ryan

(In [8256]) Gears and styling updates for Press This from azaozz. see #6813

07/09/08 21:25:09 changed by noel

  • attachment press-this_7-9-5pm.diff added.

CSS cleanup, photo input newline breaks, fixes short_tags problem

07/09/08 21:39:37 changed by ryan

(In [8303]) Press This: CSS cleanup, photo input newline breaks, fixes short_tags problem. Props noel. see #6813

07/11/08 00:54:10 changed by noel

  • attachment press-this_7-10-9pm.diff added.

Fixes continuous linking issue by using rlm entity;

07/11/08 02:18:35 changed by noel

IE css fixes are almost complete.

07/11/08 04:22:50 changed by noel

  • attachment press-this-ie.css added.

wp-admin/css/ IE stylesheet

07/11/08 04:31:25 changed by noel

  • attachment press-this_7-11-1am.diff added.

IE CSS stylesheet conditional comment

07/11/08 11:13:27 changed by azaozz

  • attachment pess-this-selection-fix.patch added.

Fixes inserting the selection in the editor and stripping of paragraphs when saving.

07/11/08 12:48:06 changed by paulhontz

Does this also include a link back to the original article?

07/11/08 15:17:05 changed by ryan

Can I get a cumulative patch with all of these changes in it.

Also, can the IE stylesheet be loaded via the style loader so that gears will know about it?

07/11/08 15:20:50 changed by ryan

paulhontz, do you mean in the text tab? I think we don't link back in the Text tab if a selection is being passed, which is the way Tumblr and some others behave, IIRC. We should provide a link back for the Quote tab, however. I'm open to adding a link back to the Text tab though.

07/11/08 15:47:56 changed by paulhontz

I think adding a link on the text tab would be a very beneficial feature. If you come across a cool article, I think it would be more kind to the original author if you took an excerpt, and automatically had a link back to his site (where the content originated).

thanks ryan!

07/11/08 15:57:34 changed by paulhontz

I think it would also make a great addition to any tab.

For example:

[Picture you selected] "Content content content content" url link back

I think this would make a lot of sense. Also, is it possible to pass highlighted pictures through the bookmarklet?

07/11/08 19:46:20 changed by noel

  • attachment press-this-combined_7-11.patch added.

Combined patches from azaozz and noel.

07/11/08 20:27:51 changed by ryan

(In [8316]) Press This: Fix inserting the selection in the editor and stripping of paragraphs when saving, IE CSS styling fixes, fix continuous linking in editor. Props noel and azaozz. see #6813

07/11/08 23:17:14 changed by azaozz

  • attachment pess-this-content-fix.patch added.

07/11/08 23:22:30 changed by azaozz

Switching to using our default content cleanup in the editor. Tried it for the patch yesterday, but didn't work in IE. Turns out the IE on my computer was having problems, not the code.

07/11/08 23:38:32 changed by ryan

(In [8318]) Press This: Switching to using our default content cleanup in the editor. Props azaozz. see #6813

07/13/08 04:20:48 changed by azaozz

  • attachment press-this-20080712.patch added.

07/13/08 04:21:40 changed by azaozz

  • attachment press-this-ie.2.css added.

07/13/08 04:24:23 changed by azaozz

Few small fixes: properly add and load press-this-ie.css, cleanup of the bookmarklet code.

07/13/08 04:57:02 changed by ryan

(In [8323]) Press This: properly add and load press-this-ie.css, cleanup of the bookmarklet code. Props azaozz. see #6813

07/14/08 17:26:31 changed by ryan

(In [8330]) rlm entity not so Windows friendly. Use perios instead. see #6813

07/14/08 17:56:32 changed by noel

  • attachment press-this_7-14.patch added.

Fixes issue with Flickr and some other url variations

07/14/08 17:59:06 changed by ryan

(In [8332]) Image regex fixes from noel. see #6813

07/15/08 17:23:08 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 2.9 to 2.6.