Ticket #6986 (closed defect: fixed)

Opened 5 months ago

Last modified 2 months ago

Plugin Automatic Update via FTP - SLL option will not deactivate once activated

Reported by: carltonbale Assigned to: anonymous
Priority: normal Milestone: 2.6
Component: Administration Version: 2.5.1
Severity: normal Keywords: plugin automatic upgrade FTP SSL has-patch commit
Cc:

Description

In WordPress 2.5.0 and 2.5.1, plugin automatic update was working properly via FTP. I then decided to try the FTP SSL option and received the error message

"Error: There was an error connecting to the server, Please verify the settings are correct."

So apparently my server does not support FTP over SSL. So I disabled the SSL option by setting "Use SSL" to "No". However, I continued to receive the same connection error message as above. The message would appear no matter what was entered into the FTP configuration page.

I finally added the following line to my wp-config.php file: 

define('FTP_SSL', false);

This caused the SSL setting within the plugin FTP updater to be overwritten with the correct value. FTP updates of plugins began to again function properly after making this change.

Attachments

6986.diff (1.0 kB) - added by DD32 on 05/18/08 03:07:52.

Change History

05/18/08 03:06:41 changed by DD32

This is due to a rather anoying thing with PHP: 

$string = "0";
var_dump( empty($string) ); = true
}}
A string with only a 0 is classified as an empty string.

Attached patch sets it based on if the item was post'd along or not.

05/18/08 03:07:52 changed by DD32

  • attachment 6986.diff added.

05/18/08 03:08:08 changed by DD32

  • keywords changed from plugin automatic upgrade FTP SSL to plugin automatic upgrade FTP SSL has-patch commit.

05/18/08 20:09:55 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7949]) Fix FTP SSL setting. Props DD32. fixes #6986 for trunk

05/18/08 20:10:10 changed by ryan

(In [7950]) Fix FTP SSL setting. Props DD32. fixes #6986 for 2.5

07/15/08 16:24:07 changed by ryan

  • milestone changed from 2.5.2 to 2.9.

Milestone 2.5.2 deleted

07/30/08 20:34:39 changed by westi

  • milestone changed from 2.9 to 2.6.