Ticket #7176 (closed enhancement: fixed)

Opened 5 months ago

Last modified 3 months ago

Grammar in Gears Enabled Dialog

Reported by: Speedboxer Assigned to: westi
Priority: low Milestone: 2.7
Component: Administration Version: 2.6
Severity: minor Keywords: has-patch
Cc:

Description

In the Gears enabled and installed dialog box, I believe that browser in this line, should be possessive (genitive?):

You can disable it from your browser Tools menu.

I also think that this line:

If there are any errors, try disabling Gears, then reload the page and enable it again.

Feels awkward, and I suggest this:

`If there are any errors, try disabling Gears, reloading the page and re-enabling Gears.

Attachments

gears-grammar-fixes.diff (1.1 kB) - added by Speedboxer on 06/24/08 19:59:47.
Grammar Fixes for Gears Enabled Box
7176.diff (1.1 kB) - added by ionfish on 06/24/08 20:54:58.
gears-grammar-fixes2.diff (1.1 kB) - added by Speedboxer on 06/24/08 21:01:05.
Changed the _e() quotes back to single.
gears-grammar-fixes3.diff (1.7 kB) - added by Speedboxer on 07/23/08 20:07:34.
Make patch work with latest commits.
gears-grammar-fixes4.diff (1.7 kB) - added by Speedboxer on 08/17/08 20:44:38.
Update patch
gears-grammar-fixes5.diff (3.7 kB) - added by Speedboxer on 08/26/08 21:06:45.
More changes
gears-grammar-fixes6.diff (3.7 kB) - added by Speedboxer on 08/26/08 21:39:49.
Invert the shared/public computer sentence.

Change History

06/24/08 19:59:47 changed by Speedboxer

  • attachment gears-grammar-fixes.diff added.

Grammar Fixes for Gears Enabled Box

06/24/08 20:18:13 changed by Speedboxer

  • keywords set to has-patch.

06/24/08 20:54:58 changed by ionfish

  • attachment 7176.diff added.

06/24/08 20:55:36 changed by ionfish

Updated the patch with a nicer apostrophe.

06/24/08 21:01:05 changed by Speedboxer

  • attachment gears-grammar-fixes2.diff added.

Changed the _e() quotes back to single.

06/24/08 21:02:17 changed by Speedboxer

Updated the patch to use single-quotes instead of double-quotes, since the "nicer" apostrophe doesn't need them.

06/24/08 21:05:48 changed by ionfish

Oops, missed those. Cheers.

07/13/08 14:14:57 changed by lloydbudd

  • priority changed from normal to low.
  • severity changed from normal to minor.
  • milestone changed from 2.6 to 2.7.

2.6 ship has sailed for non-critical bugs.

07/23/08 20:07:34 changed by Speedboxer

  • attachment gears-grammar-fixes3.diff added.

Make patch work with latest commits.

07/23/08 20:08:55 changed by Speedboxer

Updated patch to work with the latest Safari-related Gears commits.

08/17/08 11:26:38 changed by westi

  • keywords changed from has-patch to needs-patch.
  • owner changed from anonymous to westi.
  • status changed from new to assigned.

+1

Patch no longer applies.

Needs updating.

08/17/08 20:44:38 changed by Speedboxer

  • attachment gears-grammar-fixes4.diff added.

Update patch

08/17/08 20:45:20 changed by Speedboxer

  • keywords changed from needs-patch to has-patch.

Patch has been updated.

08/26/08 11:48:48 changed by caesarsgrunt

Comma usage is incorrect in the original and in the proposed correction. The first comma should be removed.

Suggestion :
If there are any errors try disabling Gears, reloading the page, and re-enabling Gears.

Or (if you don't like the Oxford comma) :
If there are any errors try disabling Gears, reloading the page and re-enabling Gears.
But this second one is, IMO, not very clear.

08/26/08 21:06:45 changed by Speedboxer

  • attachment gears-grammar-fixes5.diff added.

More changes

08/26/08 21:08:00 changed by Speedboxer

I fixed that, and made a few more changes. Let me know what you think.

(follow-up: ↓ 12 ) 08/26/08 21:28:29 changed by caesarsgrunt

I like most of the changes, but I'm not sure about
However, if this is a public or shared computer, Gears should not be enabled.

I don't really like the commas there - those could be parenthetical commas, setting off an unessential part of the sentence. Perhaps
However, if this is a public or shared computer Gears should not be enabled.
or even
However, Gears should not be enabled if this is a public or shared computer.
would be better.
Or maybe even
Gears should not, however, be enabled if this is a public or shared computer.
Not sure which is best...

(in reply to: ↑ 11 ) 08/26/08 21:35:59 changed by Speedboxer

Replying to caesarsgrunt:

I like most of the changes, but I'm not sure about
However, if this is a public or shared computer, Gears should not be enabled.

I'm not sure, I asked someone I know who's a Writer, and he said it was okay. Although, he also said you could also invert the sentence (your third one). I think I'll go with that. I'll go update the patch now.

08/26/08 21:39:49 changed by Speedboxer

  • attachment gears-grammar-fixes6.diff added.

Invert the shared/public computer sentence.

08/26/08 21:53:05 changed by caesarsgrunt

Yes, I think that's good.

08/27/08 06:33:03 changed by westi

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8741]) Improve grammar in Gears Enable Dialog. Fixes #7176 props Speedboxer.