Ticket #7281 (closed enhancement: fixed)

Opened 5 months ago

Last modified 1 month ago

Toggle to select Flash or legacy uploader

Reported by: tellyworth Assigned to: anonymous
Priority: normal Milestone: 2.6
Component: General Version: 2.6
Severity: normal Keywords: has-patch
Cc:

Description

This adds a link toggle to the upload page that allows the user to switch to the legacy HTML form uploader if they're having problems with the Flash uploader. (That happens automatically if Flash is not installed; the patch lets the user override the auto detection and force HTML even if they have Flash installed).

It could alternatively be implemented as a plugin, since it relies solely on actions and filters.

Attachments

upload-flash-bypass-r8309.patch (2.0 kB) - added by tellyworth on 07/11/08 01:40:45.
add_query_arg.diff (1.3 kB) - added by xknown on 07/11/08 03:18:15.
add_query_arg sanitization

Change History

07/11/08 01:40:45 changed by tellyworth

  • attachment upload-flash-bypass-r8309.patch added.

07/11/08 01:45:42 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [8310]) Add flash uploader bypass toggle. Props tellyworth. fixes #7281

07/11/08 03:05:23 changed by DD32

How does this fare for people using the no flash uploader? I have a feeling the plugin may completely override this.. If it was to hook in late (say 11), then it'll take priority over any plugins which modify it. (re-open if anyone feels like thats a good idea)

07/11/08 03:05:37 changed by DD32

  • version set to 2.6.
  • milestone changed from 2.7 to 2.6.

07/11/08 03:07:47 changed by DD32

How does this fare for people using the no flash uploader?

By that i meant the no flash uploader plugins, eg http://wordpress.org/extend/plugins/no-flash-uploader/

07/11/08 03:18:15 changed by xknown

  • attachment add_query_arg.diff added.

add_query_arg sanitization

07/11/08 03:24:40 changed by xknown

  • status changed from closed to reopened.
  • resolution deleted.

Sorry for the unrelated new patch, there was two little security problems in [8310] and I didn't want to open a new ticket.

07/11/08 15:11:12 changed by ryan

(In [8312]) clean_url() for add_query_arg(). Props xnown. see #7281

10/22/08 17:24:27 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from 2.9 to 2.6.