Ticket #7520 (reopened enhancement)

Opened 5 months ago

Last modified 3 weeks ago

Image default options for size, alignment and link type

Reported by: tellyworth Assigned to: azaozz
Priority: high Milestone: 2.7.1
Component: General Version: 2.7
Severity: normal Keywords: needs-patch
Cc:

Description

This adds options to Settings/Misc that let you specify default values for the image size, alignment and link type (post/file/none). The, uh, default defaults are as per 2.6 behaviour.

Further work is needed to apply the defaults to the upload form, this currently works only in the media library tab.

Attachments

image-default-options-r8645.patch (9.7 kB) - added by tellyworth on 08/14/08 12:45:50.
image-default-options-r8652-2.patch (11.7 kB) - added by tellyworth on 08/15/08 07:13:42.
improved patch works with external images also

Change History

08/14/08 12:45:50 changed by tellyworth

  • attachment image-default-options-r8645.patch added.

08/14/08 22:53:25 changed by tellyworth

  • keywords set to has-patch.

Guh. No writing patch descriptions before bedtime. This *does* work for the upload form, and the gallery tab too. The 'From URL' form for inserting an external image is the only part that doesn't respect the options. That needs to be added but I'd like to see the patch go in as-is for testing and feedback first.

08/15/08 07:13:42 changed by tellyworth

  • attachment image-default-options-r8652-2.patch added.

improved patch works with external images also

08/15/08 15:40:37 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [8653]) Image default options for size, alignment and link type. Props tellyworth. fixes #7520

08/26/08 15:02:52 changed by matt

  • status changed from closed to reopened.
  • resolution deleted.

This is option bloat - we should just remember and default to whatever you used last, just like with Visual / HTML.

10/02/08 22:18:41 changed by lloydbudd

  • keywords changed from has-patch to needs-patch.
  • version set to 2.7.

10/02/08 22:32:12 changed by tellyworth

Fair enough. Removing the hard-coded defaults isn't a bad thing to do. I'd suggest keeping that part, move them to hidden options, and drop the UI. That way if someone wants to they can write a plugin that provides a UI for setting them -- or overrides them in some other way with filters.

10/16/08 22:20:40 changed by ryan

#6655 related

10/17/08 20:01:35 changed by ryan

  • owner changed from anonymous to azaozz.
  • priority changed from normal to high.
  • status changed from reopened to new.

11/13/08 03:07:39 changed by azaozz

  • status changed from new to closed.
  • resolution set to fixed.

(In [9654]) Keep state for image size, alignment and url in the uploader and for categories view on the write page, fixes #7520

11/13/08 03:10:15 changed by azaozz

(In [9655]) Refresh js, see #7520

12/15/08 21:52:10 changed by randyhoyt

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.7 to 2.7.1.

The new hidden options aren't working correctly. If you look at the HTML, it looks like the proper radio buttons have a value of checked="checked", but something else is overriding those selections. Is this a bug, or was tellyworth's suggestion to hide these options rejected?

If it was rejected, I want to reopen this bug and argue in favor or tellyworth's suggestion. I disagree that having these default options is "feature bloat". Every site I have worked on has a most-used behavior (thumbnails links to the post URL, for example, or medium images with no links). Every now and then, the user will need to deviate from this (adding a large image with a link to an external web site, for example). A week later, when the user logs in, they expect it to work the way it usually does. They won't remember whether the last time they uploaded an image, they used the most-used behavior or something different. The users expectations are not shaped by what they did last week, and I would argue that the applications behavior shouldn't either.

(I would also make this same argument regarding the Visual Editor / HTML Editor. Every single time I switch over to the HTML editor, save something, and navigate to a different post, it is a jarring experience that goes against my expectations when the HTML editor loads. But since there are only two options and most of my clients don't use the HTML editor, I don't think it's a big deal.)