Ticket #8061 (closed defect (bug): fixed)

Opened 2 months ago

Last modified 2 months ago

Pressing Enter in Quick Edit

Reported by: aaron_guitar Assigned to: anonymous
Priority: normal Milestone: 2.7
Component: General Version: 2.7
Severity: normal Keywords:
Cc:

Description

When you press enter in the quick edit input fields, it submits #post-filter form instead of saving the changes to the post.

Attachments

8061.patch (1.2 kB) - added by aaron_guitar on 11/07/08 15:30:20.

Change History

11/04/08 23:30:11 changed by azaozz

  • status changed from new to closed.
  • resolution set to invalid.

"Enter" cannot be used to save the QE as it is part of the large form on the page that includes all rows. Trying to do it from JS doesn't work well in all browsers.

Closing as invalid, feel free to reopen if there's a patch that would do this reliably in all browsers.

11/07/08 15:30:20 changed by aaron_guitar

  • attachment 8061.patch added.

11/07/08 15:37:12 changed by aaron_guitar

  • status changed from closed to reopened.
  • resolution deleted.

Tested and working in Firefox 2, 3; Safari 3; IE 6, 7; Chrome.

11/07/08 15:50:15 changed by jacobsantos

aaron_guitar gets the Kicks-Ass reward.

11/07/08 19:05:19 changed by mrmist

Patch seems ok in Opera, too. The very first time that I tried it, it seemed that the changes I made to the post title were not reflected on the page, but I've not been able to reproduce that since.

11/08/08 06:34:18 changed by azaozz

Yes, something like that was the first thing I tried too, problem is that it only works when the cursor is in an input field, so when you select something from a drop-down or enter some tags (they use textarea), this doesn't work.

11/08/08 06:54:43 changed by azaozz

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9566]) Press Enter to save in Quick Edit, props aaron_guitar, fixes #8061

11/08/08 06:56:50 changed by azaozz

Still won't save when the tags textarea is focused (user should be able to type Enter in textareas), the rest should work well.

11/08/08 15:28:23 changed by aaron_guitar

The problem with the textarea is that when you press enter to select a tag from autocompletion, it will save the row. Also, if you press enter in the tags before making any edits, it triggers the autocomplete which then pops up in the upper left corner of the screen. I'll work on a solution for this.