Ticket #8142 (closed defect (bug): fixed)

Opened 2 months ago

Last modified 2 months ago

misc i18n fixes for 2.7

Reported by: nbachiyski Assigned to: anonymous
Priority: normal Milestone: 2.7
Component: i18n Version:
Severity: normal Keywords:
Cc:

Description

  • Admin paging: __( 'Displaying %s&#8211;%s of %s' ) . '</span>' . __( '%s' )

The last %s doesn't have to be i18n-ed.

  • Delete confirmations: 
    var n = $('#the-list input[type="checkbox"]:checked').length;
var m = n > 1 ? '<plural message>' : 'singular message';

Pluralization by hand is a bad idea. Plural only confirmations sound well enough in English.

  • via -> via %s

Attachments

i18n-2.7.diff (11.2 kB) - added by nbachiyski on 11/10/08 15:13:16.
i18n-2.7-2.diff (2.7 kB) - added by nbachiyski on 11/13/08 18:57:01.
Some more js plurals and one forgotten regular plural
i18n-2.7-3-medium-differentiate.diff (0.6 kB) - added by nbachiyski on 11/19/08 10:08:37.
Differentiate between Medium occurences
i18n-2.7-4-search-form-label.diff (0.6 kB) - added by nbachiyski on 11/20/08 13:34:02.
Search form label isn't i18n-ed in get_search_form()

Change History

11/10/08 15:13:16 changed by nbachiyski

  • attachment i18n-2.7.diff added.

11/10/08 17:42:52 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [9589]) i18n fixes from nbachiyski. fixes #8142

11/13/08 18:56:30 changed by nbachiyski

  • status changed from closed to reopened.
  • resolution deleted.

11/13/08 18:57:01 changed by nbachiyski

  • attachment i18n-2.7-2.diff added.

Some more js plurals and one forgotten regular plural

11/13/08 20:59:32 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9668]) i18n plurals fixes from nbachiyski. fixes #8142

11/19/08 10:08:05 changed by nbachiyski

  • status changed from closed to reopened.
  • resolution deleted.

11/19/08 10:08:37 changed by nbachiyski

  • attachment i18n-2.7-3-medium-differentiate.diff added.

Differentiate between Medium occurences

11/19/08 17:23:09 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9789]) Add gettext context. Props nbachiyski. fixes #8142

11/19/08 19:30:49 changed by Dutchguys

  • status changed from closed to reopened.
  • resolution deleted.

Last change breaks google gears for me in WordPress 2.7-beta3-9791

11/19/08 19:50:10 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9794]) Stub _c() for gears manifest. fixes #8142

11/20/08 13:34:02 changed by nbachiyski

  • attachment i18n-2.7-4-search-form-label.diff added.

Search form label isn't i18n-ed in get_search_form()

11/20/08 13:34:09 changed by nbachiyski

  • status changed from closed to reopened.
  • resolution deleted.

11/20/08 17:03:31 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9813]) Escape gettext in attribute. Props nbachiyski. fixes #8142

11/23/08 12:52:42 changed by tai

  • status changed from closed to reopened.
  • resolution deleted.

Two more please!

in /wp-includes/comment-template.php around the line 1184: 

<div class="comment-meta commentmetadata"><a href="<?php echo htmlspecialchars( 
get_comment_link( $comment->comment_ID ) ) ?>"><?php printf(__('%1$s at %2$s'), 
get_comment_date('F jS, Y'),  get_comment_time()) ?></a><?php 
edit_comment_link('edit','&nbsp;&nbsp;','') ?></div>

get_comment_date('F jS, Y')

-> 

get_comment_date()

and 

edit_comment_link('edit','&nbsp;&nbsp;','')

-> 

edit_comment_link(__('Edit'),'&nbsp;&nbsp;','')

11/24/08 01:36:24 changed by azaozz

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9854]) I18n: fix get_comment_date and edit_comment_link in comment-template.php, props tai. Add class to "Says:", fixes #8142