Ticket #900 (closed enhancement: fixed)

Opened 4 years ago

Last modified 1 year ago

support of mt_keywords

Reported by: anonymousbugger Assigned to: rob1n
Priority: normal Milestone: 2.3
Component: XML-RPC Version: 2.2
Severity: normal Keywords: has-patch
Cc: redsweater, josephscott

Description

is missing, would be nice for use with eg technorati tags..

Attachments

xmlrpc.php.diff (4.0 kB) - added by redsweater on 04/08/07 21:45:55.
Patch to support mt_keywords as conveyance of WP native tags. (Second upload with small fix)
900.diff (3.6 kB) - added by rob1n on 04/17/07 00:38:43.
900-fixed.diff (3.6 kB) - added by westi on 04/17/07 21:26:35.
Fixed patch
tags-xmlrpc.php.diff (3.6 kB) - added by josephscott on 08/29/07 22:13:22.

Change History

02/17/05 05:23:03 changed by anonymousbugger

02/17/05 05:23:04 changed by anonymousbugger

  • Patch set to No.

02/17/05 10:44:50 changed by anonymousbugger

It shall be available to plugins once we add API hooks in xmlrpc.php.

02/17/05 11:25:49 changed by michel v

(I'm the author of the previous note.)

01/28/06 14:48:12 changed by markjaquith

  • keywords set to bg|needs-patch.
  • priority changed from normal to low.
  • milestone set to 2.1.

08/31/06 02:07:18 changed by mdawaffe

  • status changed from new to closed.
  • resolution set to wontfix.

#2061 allows a plugin to handle this. Without native support for tags in WP, I think this should remain in the plugin domain.

Feel free to reopen with other thoughts.

04/08/07 16:36:47 changed by redsweater

  • status changed from closed to reopened.
  • version changed from 1.5 to 2.2.
  • resolution deleted.
  • milestone changed from 2.1 to 2.2.

In light of the last comment, it may be time to reopen this? Since 2.2 is adding native tagging support, the xmlrpc.php interface should support the mt_keywords parameter for MovableType?.

If nobody else is inclined to work on this right now, I can probably do it.

I would recommend changing the priority from low to at least normal, since the missing functionality is glaring in the context of the native tagging support.

Daniel

04/08/07 17:14:22 changed by rob1n

Yep. Feel free to attach a patch, then assign it to me for looking over and possibly committing :).

04/08/07 17:14:29 changed by rob1n

  • keywords changed from bg|needs-patch to needs-patch.
  • priority changed from low to normal.

04/08/07 19:46:29 changed by redsweater

Attaching patch, xmlrpc.php.diff.

Summary:

- Accept mt_keywords input as comma-separated tag names, supplied to wp_insert_post and wp_update_post.

- Convey get_post_tags result as comma-separated string to generated XML for getRecentPosts and getPost.

One part I'm not sure about is the way I added an include() for wp-admin/admin-db.php near the top of xmlrpc.php. There is some assumption of implicitly included libraries, where the category_exists() function is used in post.php. This include fixes the problem but I'm not sure that's the correct way to solve it.

Daniel

04/08/07 20:32:57 changed by redsweater

  • cc set to redsweater.

04/08/07 21:17:10 changed by redsweater

  • keywords changed from needs-patch to has-patch.

04/08/07 21:45:55 changed by redsweater

  • attachment xmlrpc.php.diff added.

Patch to support mt_keywords as conveyance of WP native tags. (Second upload with small fix)

04/10/07 09:47:06 changed by matt

More importantly, I think we need a API call in XML-RPC for tags.

04/10/07 12:12:54 changed by redsweater

A dedicated API would probably be a good idea, especially if it gives more info (e.g. tell me all tags that have been used on this blog).

But seeing as some emphasis has been made on smoothing the transition for UTW users, I think this patch would be a good way to offer a blunt interface to the tags repository that matches the existing behavior of UTW (as I understand it, it will grab the mt_keywords of submitted posts, and ingest the items as tags).

04/11/07 21:30:53 changed by westi

This patch looks good in terms of functionality.

Pulling in an admin file in the includes feels wrong though.

The code elsewhere should be fixed instead.

04/12/07 18:30:29 changed by foolswisdom

  • keywords changed from has-patch to developer-feedback.
  • milestone changed from 2.2 to 2.3.

04/12/07 18:36:09 changed by redsweater

Does pushing this to 2.3 mean there will be no XML-RPC interface to getting/setting tags in 2.2?

04/15/07 14:54:22 changed by westi

  • keywords changed from developer-feedback to has-patch commit.
  • milestone changed from 2.3 to 2.2.

reviewing this further it looks like that new include is not actually needed as nowhere in post.php calls category_exists

I think this patch should go into 2.2 minus the extra include line.

04/15/07 21:22:43 changed by rob1n

  • owner changed from anonymous to rob1n.
  • status changed from reopened to new.

04/17/07 00:38:43 changed by rob1n

  • attachment 900.diff added.

04/17/07 01:30:12 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5278]) Add mt_keywords support. Props redsweater. fixes #900

04/17/07 01:32:35 changed by redsweater

Sweet!! Thanks for picking this up, rob1n.

04/17/07 19:26:36 changed by rob1n

  • status changed from closed to reopened.
  • resolution deleted.

Apparently it breaks something.

(follow-up: ↓ 24 ) 04/17/07 20:28:15 changed by redsweater

Bummer. Maybe the breakage can be documented here for posterity?

(in reply to: ↑ 23 ) 04/17/07 21:25:55 changed by westi

Replying to redsweater:

Bummer. Maybe the breakage can be documented here for posterity? 

Fatal error:  Call to undefined function get_post_tags() in
/home/peter/www/trunk/xmlrpc.php on line 1330

Fixed patch coming up

04/17/07 21:26:35 changed by westi

  • attachment 900-fixed.diff added.

Fixed patch

04/19/07 03:06:11 changed by rob1n

  • keywords changed from has-patch commit to has-patch.
  • milestone changed from 2.2 to 2.3.

Tags are moving to 2.3.

08/27/07 14:13:27 changed by josephscott

  • cc changed from redsweater to redsweater, josephscott.

08/29/07 22:13:22 changed by josephscott

  • attachment tags-xmlrpc.php.diff added.

08/29/07 22:27:54 changed by josephscott

The new patch I've uploaded is based off the 900-fixed.diff. I fixed the error noted earlier and confirmed that tags can be set for new posts and are returned for existing posts.

08/29/07 23:01:48 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5981]) mt_keywords support. Props westi and josephscott. fixes #900