Ticket #967 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

publish_post is not triggered via xml-rpc or email posting

Reported by: anonymousbugger Assigned to: skippy
Priority: low Milestone:
Component: XML-RPC Version: 1.5
Severity: minor Keywords: bg|2nd-opinion bg|has-patch
Cc: majelbstoat, bjcameron, echozone

Description

publish_post is not triggered when someone uses a program that posts via xml-rpc (w.bloggar for instance) or when someone posts by email

Attachments

add publish_post, edit_post hooks for xmlrpc posting.diff (1.6 kB) - added by anonymousbugger on 05/21/05 06:35:20.

Change History

02/24/05 14:39:10 changed by anonymousbugger

  • Patch set to No.

02/24/05 15:20:50 changed by majelbstoat

Uploaded a patch which adds the required hooks. Actually, just lifted the same code from post.php, but haven't had a chance to test it out yet. Also adds hooks for trackbacks, enclosures, and pingbacks if specified. Quick and dirty, and in need of review before committing, but might do the trick. J.

02/24/05 15:31:08 changed by majelbstoat

Forgot to mention, didn't touch email posting for now, as it has the action 'publish_phone' hooked in. Maybe plugins that add an action for publish_post should silently have a publish_phone action added as well? Would produce the most expected behaviour IMHO. Either that or copy the same code block again? If that was the case it would be reproduced 6 times (and thus a possible candidate for being its own reusable function maybe?)

02/24/05 17:25:01 changed by michel v

Actually, what is needed is specific XMLRPC hooks. We can not copy hooks made with a particular purpose in mind and expect they'll work the same elsewhere. For example with this patch, do_trackbacks() wouldn't trackback anything when making a new post, because the field to_ping wouldn't be populated yet.

04/12/05 13:49:34 changed by briangroce

Any update on this?

05/21/05 06:35:20 changed by anonymousbugger

  • attachment add publish_post, edit_post hooks for xmlrpc posting.diff added.

06/30/05 14:25:32 changed by skippy

  • keywords set to bg|2nd-opinion bg|needs-patch.
  • owner changed from anonymous to skippy.
  • status changed from new to assigned.
  • priority changed from normal to low.

06/30/05 14:26:01 changed by skippy

  • keywords changed from bg|2nd-opinion bg|needs-patch to bg|2nd-opinion bg|has-patch.

06/30/05 17:14:44 changed by markjaquith

According to michel_v's logic, we'd need a publish_xmlrpc hook...

06/30/05 20:02:52 changed by skippy

But according to Ryan, the new workflow uses the same process for all posts, regardless of how they come in. We could have a publish_xmlrpc hook (like publish_phone), for actions specific to that kind of posting, but those are still considered posts and should trigger publish_post.

08/11/05 12:40:54 changed by skippy

  • milestone set to 1.5.2.

08/14/05 18:06:06 changed by matt

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [2780]) Fixes #967, Fixes #972, Fixes #1578, Fixes #1580, Fixes #1567, Fixes #1481, Fixes #1186

11/30/06 19:41:47 changed by

  • milestone deleted.

Milestone 1.5.2 deleted