Ticket #1065 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

Detect Whether a User is Logged in for Popup Comments as well

Reported by: tin Assigned to: rob1n
Priority: low Milestone: 2.2
Component: Template Version: 2.1
Severity: minor Keywords: has-patch commit
Cc:

Description

I really like the feature where a person does not have to fill out his/her Name, Email Address and Website URL when he/she is logged into the blog. However, when using popup comments, this feature does not exist. Can you port this feature over to the popup comments as well? Thanks!

Attachments

1065.patch (2.0 kB) - added by skippy on 11/06/05 03:07:02.
1065b.diff (3.9 kB) - added by Nazgul on 10/06/06 10:48:02.
1065_current.diff (2.7 kB) - added by rob1n on 02/15/07 01:12:45.
1065_current.2.diff (2.7 kB) - added by rob1n on 02/16/07 04:21:56.

Change History

03/09/05 10:04:14 changed by tin

  • Patch set to No.

05/20/05 20:19:26 changed by prissed

Same thing here.

I tried adding if ($user_ID)...when doing that, displays the "logged in" box, but when submitting the form, it returns to a blank page. And nothing is inserted into the db.

11/06/05 03:07:02 changed by skippy

  • attachment 1065.patch added.

11/06/05 03:08:15 changed by skippy

  • keywords set to bg|has-patch bg|commit bg|squashed.
  • owner changed from anonymous to skippy.
  • status changed from new to assigned.
  • component changed from General to Template.
  • version changed from 1.5 to 1.6.

1065.patch patches only the default theme's comments-popup.php

10/06/06 10:48:02 changed by Nazgul

  • attachment 1065b.diff added.

10/06/06 10:49:11 changed by Nazgul

  • keywords changed from bg|has-patch bg|commit bg|squashed to has-patch.
  • owner deleted.
  • status changed from assigned to new.
  • milestone set to 2.1.

Patch refreshed.

11/29/06 22:37:25 changed by matt

  • milestone changed from 2.1 to 2.2.

02/15/07 01:07:04 changed by rob1n

  • status changed from new to assigned.
  • severity changed from normal to minor.
  • priority changed from normal to low.
  • owner set to rob1n.
  • version changed from 1.6 to 2.1.
  • keywords changed from has-patch to needs-patch.

Patch doesn't apply anymore. Working on a new patch.

02/15/07 01:12:45 changed by rob1n

  • attachment 1065_current.diff added.

02/15/07 01:13:20 changed by rob1n

  • keywords changed from needs-patch to has-patch commit.

Added a current patch on r4884.

02/15/07 03:52:12 changed by markjaquith

The code should match that in each theme's respective comments.php There shouldn't be any i18n functions (like __()), as themes are not localized.

02/15/07 21:56:03 changed by rob1n

  • keywords changed from has-patch commit to needs-patch.

Ah, I didn't know that. I'll work on a new patch without i18n when I get home.

02/16/07 04:21:56 changed by rob1n

  • attachment 1065_current.2.diff added.

02/16/07 04:22:37 changed by rob1n

  • keywords changed from needs-patch to has-patch commit.

New patch added that doesn't use localization.

02/16/07 04:36:54 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4890]) Detect whether a user is logged in for popup comments templates in default and classic themes. props skippy, Nazgul, rob1n. fixes #1065