WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 17 years ago

#1065 closed enhancement (fixed)

Detect Whether a User is Logged in for Popup Comments as well

Reported by: tin's profile tin Owned by: rob1n's profile rob1n
Milestone: 2.2 Priority: low
Severity: minor Version: 2.1
Component: Template Keywords: has-patch commit
Focuses: Cc:

Description

I really like the feature where a person does not have to fill out his/her Name, Email Address and Website URL when he/she is logged into the blog. However, when using popup comments, this feature does not exist. Can you port this feature over to the popup comments as well? Thanks!

Attachments (4)

1065.patch​ (2.0 KB) - added by skippy 19 years ago.
1065b.diff​ (3.9 KB) - added by Nazgul 18 years ago.
1065_current.diff​ (2.7 KB) - added by rob1n 17 years ago.
1065_current.2.diff​ (2.7 KB) - added by rob1n 17 years ago.

Download all attachments as: .zip

Change History (15)

#1 @tin
19 years ago

  • Patch set to No

#2 @prissed
19 years ago

Same thing here.

I tried adding if ($user_ID)...when doing that, displays the "logged in" box, but when submitting the form, it returns to a blank page. And nothing is inserted into the db.

@skippy
19 years ago

#3 @skippy
19 years ago

  • Component changed from General to Template
  • Keywords bg|has-patch bg|commit bg|squashed added
  • Owner changed from anonymous to skippy
  • Status changed from new to assigned
  • Version changed from 1.5 to 1.6

1065.patch patches only the default theme's comments-popup.php

@Nazgul
18 years ago

#4 @Nazgul
18 years ago

  • Keywords has-patch added; bg|has-patch bg|commit bg|squashed removed
  • Milestone set to 2.1
  • Owner skippy deleted
  • Status changed from assigned to new

Patch refreshed.

#5 @matt
17 years ago

  • Milestone changed from 2.1 to 2.2

#6 @rob1n
17 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to rob1n
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Status changed from new to assigned
  • Version changed from 1.6 to 2.1

Patch doesn't apply anymore. Working on a new patch.

@rob1n
17 years ago

#7 @rob1n
17 years ago

  • Keywords has-patch commit added; needs-patch removed

Added a current patch on r4884.

#8 @markjaquith
17 years ago

The code should match that in each theme's respective comments.php There shouldn't be any i18n functions (like __()), as themes are not localized.

#9 @rob1n
17 years ago

  • Keywords needs-patch added; has-patch commit removed

Ah, I didn't know that. I'll work on a new patch without i18n when I get home.

@rob1n
17 years ago

#10 @rob1n
17 years ago

  • Keywords has-patch commit added; needs-patch removed

New patch added that doesn't use localization.

#11 @markjaquith
17 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4890]) Detect whether a user is logged in for popup comments templates in default and classic themes. props skippy, Nazgul, rob1n. fixes #1065

Note: See TracTickets for help on using tickets.