Comments RSS Feed: remove limit on page/post feeds

[alexkingorg]

I couldn't figure out how to upload my patch, so here it is:

33,34c33,34
< 			comment_author_url, comment_date, comment_date_gmt, comment_content, comment_post_ID, 
< 			$wpdb->posts.ID, $wpdb->posts.post_password FROM $wpdb->comments 
---
> 			comment_author_url, comment_date, comment_content, comment_post_ID, 
> 			$wpdb->posts.ID, $wpdb->posts.post_password, $wpdb->posts.post_title FROM $wpdb->comments 
38c38
< 			ORDER BY comment_date DESC LIMIT " . get_settings('posts_per_rss') );
---
> 			ORDER BY comment_date";
42c42
< 			$wpdb->posts.ID, $wpdb->posts.post_password FROM $wpdb->comments 
---
> 			$wpdb->posts.ID, $wpdb->posts.post_password, $wpdb->posts.post_title FROM $wpdb->comments 
52c52
< 		<title>by: <?php comment_author_rss() ?></title>
---
> 		<title><?php comment_author_rss() ?> on '<?php echo $comment->post_title; ?>'</title>

[alexkingorg]

patch

[alexkingorg]

Ah, you get to add the file *after* you create the ticket.

[markjaquith]

The title thing got added in 1.5.2, so I'm editing the title to only reference the limit issue.

Anyone have an opinion on the limit issue? without it, the feed could be VERY big. We've all had our 100+ comments entries. But then, it is a comment feed, so the limit is too low, someone might miss comments. How about hardcoding a high limit? Say... 40?

[dougal]

I'd suggest using the limit from options, but accepting a querystring parameter to override it. E.g.:

​http://example.com/archives/2005/10/21/feed/?itemcount=100

[matt]

Not going in 2.0.

[Nazgul]

What are the opinions on this?
Should the comment feed also abide the posts_per_rss option?

Also Tortoise doesn't like the currently attached patch. Is it Tortoise or is it the patch?

[alexkingorg]

The comments feed is to comments display as the posts feed is to the posts display. That is, the posts and posts feed are both in reverse-chronological order. The comments and comments feed are in chronological order. The limit effectively cuts off comments at that limit. A better way to limit would be to get the number of comments and set an offset too so that the latest comments are always included.

Perhaps another (updated) patch is required now.

[matt]

(In [4542]) This should be an XML representation of all comments on a post, fixes #1570