Ticket #1570 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Comments RSS Feed: remove limit on page/post feeds

Reported by: alexkingorg Assigned to: markjaquith
Priority: low Milestone: 2.1
Component: General Version: 1.5.1.2
Severity: normal Keywords: 2nd-opinion has-patch
Cc:

Description

I couldn't figure out how to upload my patch, so here it is:

33,34c33,34
< 			comment_author_url, comment_date, comment_date_gmt, comment_content, comment_post_ID, 
< 			$wpdb->posts.ID, $wpdb->posts.post_password FROM $wpdb->comments 
---
> 			comment_author_url, comment_date, comment_content, comment_post_ID, 
> 			$wpdb->posts.ID, $wpdb->posts.post_password, $wpdb->posts.post_title FROM $wpdb->comments 
38c38
< 			ORDER BY comment_date DESC LIMIT " . get_settings('posts_per_rss') );
---
> 			ORDER BY comment_date";
42c42
< 			$wpdb->posts.ID, $wpdb->posts.post_password FROM $wpdb->comments 
---
> 			$wpdb->posts.ID, $wpdb->posts.post_password, $wpdb->posts.post_title FROM $wpdb->comments 
52c52
< 		<title>by: <?php comment_author_rss() ?></title>
---
> 		<title><?php comment_author_rss() ?> on '<?php echo $comment->post_title; ?>'</title>

Attachments

diff.txt (0.8 kB) - added by alexkingorg on 08/10/05 04:57:56.
patch

Change History

08/10/05 04:57:56 changed by alexkingorg

  • attachment diff.txt added.

patch

08/10/05 05:00:31 changed by alexkingorg

Ah, you get to add the file *after* you create the ticket.

08/15/05 07:47:15 changed by markjaquith

  • status changed from new to assigned.
  • summary changed from Patch to comments RSS feed, add post title to feed item title element, remove limit on page/post feeds to Comments RSS Feed: remove limit on page/post feeds.
  • priority changed from normal to low.
  • owner changed from anonymous to markjaquith.
  • version changed from 1.5.2 to 1.5.1.2.
  • milestone set to 1.6.
  • keywords set to bg|2nd-opinion.

The title thing got added in 1.5.2, so I'm editing the title to only reference the limit issue.

Anyone have an opinion on the limit issue? without it, the feed could be VERY big. We've all had our 100+ comments entries. But then, it is a comment feed, so the limit is too low, someone might miss comments. How about hardcoding a high limit? Say... 40?

11/22/05 14:47:43 changed by dougal

I'd suggest using the limit from options, but accepting a querystring parameter to override it. E.g.:

http://example.com/archives/2005/10/21/feed/?itemcount=100

11/25/05 04:21:31 changed by matt

  • milestone changed from 2.0 to 2.1.

Not going in 2.0.

08/14/06 19:50:55 changed by rgovostes

  • keywords changed from bg|2nd-opinion to bg|2nd-opinion has-patch.

10/04/06 00:58:38 changed by Nazgul

  • keywords changed from bg|2nd-opinion has-patch to 2nd-opinion has-patch.

What are the opinions on this? Should the comment feed also abide the posts_per_rss option?

Also Tortoise doesn't like the currently attached patch. Is it Tortoise or is it the patch?

10/25/06 06:13:29 changed by alexkingorg

The comments feed is to comments display as the posts feed is to the posts display. That is, the posts and posts feed are both in reverse-chronological order. The comments and comments feed are in chronological order. The limit effectively cuts off comments at that limit. A better way to limit would be to get the number of comments and set an offset too so that the latest comments are always included.

Perhaps another (updated) patch is required now.

11/29/06 21:02:43 changed by matt

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4542]) This should be an XML representation of all comments on a post, fixes #1570