Ticket #2379 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

RSS feeds broken in 2.01

Reported by: incursio Assigned to: anonymous
Priority: highest omg bbq Milestone:
Component: General Version: 2.0
Severity: critical Keywords: rss xml
Cc:

Description

As reported in several forum threads.

Sometimes, we get just comments, and no posts in the RSS thread. I vaguely remember seeing an option in the admin panel to choose posts vs comments but with 2.01 it seems to have disappeared.

Plus, RSS feeds do not package into XML properly when encountering an ampersand. They are breaking - also reported in forums.

Attachments

comments-fix.txt (0.6 kB) - added by joshkidd on 02/05/06 15:52:54.
fix for comments bug

Change History

02/02/06 21:19:10 changed by incursio

  • version changed from 1.2 to 2.0.

02/03/06 14:33:35 changed by incursio

Followup/summary:

This works fine: http://www.scottburkett.com/?feed=rss2

These show only comments, no posts: http://www.scottburkett.com/index.php/feed http://www.scottburkett.com/index.php/feed/rss http://www.scottburkett.com/index.php/feed/atom

Unfortunately, Technorati automatically tries to pull the last 3 examples, not the first, so new posts are not getting indexed there (which sucks).

Cheers.

02/03/06 18:11:38 changed by jdybka

Hello

Same problem here.

Shows only comments (no posts): http://www.poetryhut.com/wordpress/index.php/feed/

Shows only comments (no posts): http://www.poetryhut.com/wordpress/index.php/feed/rss

Shows only comments (no posts): http://www.poetryhut.com/wordpress/index.php/feed/atom

Shows only comments (works correctly): http://www.poetryhut.com/wordpress/index.php/comments/feed/

This feed also works correctly: http://www.poetryhut.com/wordpress/index.php?feed=rss2

My permalinks structure is set to "Date and name based."

Thanks Jilly

02/05/06 15:52:54 changed by joshkidd

  • attachment comments-fix.txt added.

fix for comments bug

02/05/06 15:57:02 changed by joshkidd

I had the same problem reported in the comments on this bug. The attached file is a change that I made to the code. After making the change, I had to create a new static page to flush the rewrite rules. Now, I get the behavior I expect:

Shows posts: [http://larameekidd.com/index.php/feed] Shows comments: [http://larameekidd.com/index.php/comments/feed]

02/05/06 20:39:26 changed by jdybka

Thank you. That fixed my problem. To flush the rewrite rules I changed my permalinks structure from "Date and name based" to another structure and then back again.

02/07/06 02:57:07 changed by jbwhong

Joshkidd, to which file do I apply your modification?

02/10/06 02:23:26 changed by joshkidd

As it says in the file, the change is to be applied to wp-includes/classes.php

02/14/06 01:30:17 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [3527]) Don't walk rewrite structure when generating comment feed rewrite rules. This fixes a bug uncovered when we switched from unions to merges. Props joshkidd. fixes #2379

02/14/06 01:30:56 changed by ryan

  • milestone set to 2.1.

02/19/06 03:37:12 changed by jbwhong

It's not my software project, but here are my two cents:

A bug this big (that breaks people's subscriptions) shouldn't wait for a distant 2.1 release.

Now that this ticket is closed you are getting others submitting duplicate tickets.

Perhaps a 2.0.2 release is in order.

02/19/06 03:39:25 changed by jbwhong

Joshkidd, sorry I couldn't figure out what file to patch based on reading the file.

How can I use your patch?

02/19/06 09:45:18 changed by davidhouse

jbwhong:

The file you need to patch is wp-includes/classes.php, as it says at the top of the patch. Simply search that file for the line with the '-' in front of it in the patch (it won't actually have a - in the actual classes.php file), then replace it with the line with the '+' in front of it in the patch (again, don't actually put the + in the file, but the rest of the line).

02/19/06 10:28:11 changed by ryan

  • status changed from closed to closed.
  • resolution set to fixed.

(In [3551]) Don't walk rewrite structure when generating comment feed rewrite rules. This fixes a bug uncovered when we switched from unions to merges. Props joshkidd. fixes #2379

02/19/06 10:53:10 changed by ryan

  • milestone changed from 2.1 to 2.0.2.

11/30/06 19:41:50 changed by

  • milestone deleted.

Milestone 2.0.2 deleted