Make WordPress Core

Opened 18 years ago

Closed 17 years ago

Last modified 17 years ago

#2509 closed enhancement (wontfix)

Plugins translating

Reported by: sewar's profile Sewar Owned by: sewar's profile Sewar
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: plugins i18n has-patch commit
Focuses: Cc:

Description

Plugins and Themes should use their own language files, not WP main language file.

The attachments contain patchs for plugins included in WP package, i will make patchs for themes later.

All strings in the plugin should be add to plugin's language file excluding strings available in WP main language file, i hope this is helpful.

Attachments (6)

akismet.diff (9.0 KB) - added by Sewar 18 years ago.
Patch for Akismet plugin.
wp-db-backup.diff (20.3 KB) - added by Sewar 18 years ago.
Patch for WordPress Database Backup plugin.
akismet.php.diff (11.4 KB) - added by Sewar 18 years ago.
Patch for Akismet plugin
wp-db-backup.php.diff (21.4 KB) - added by Sewar 18 years ago.
Patch for WordPress Database Backup plugin
akismet.php.2.diff (13.8 KB) - added by Sewar 18 years ago.
akismet.php.3.diff (14.8 KB) - added by Sewar 17 years ago.

Download all attachments as: .zip

Change History (26)

@Sewar
18 years ago

Patch for Akismet plugin.

@Sewar
18 years ago

Patch for WordPress Database Backup plugin.

#1 @davidhouse
18 years ago

  • Keywords 2nd-opinion added

#2 @ryan
18 years ago

  • Milestone changed from 2.0.2 to 2.1

Let's wait until after 2.0.2 to move these strings.

@Sewar
18 years ago

Patch for Akismet plugin

@Sewar
18 years ago

Patch for WordPress Database Backup plugin

#3 @Sewar
18 years ago

  • Keywords bg|has-patch added; translate removed
  • Owner changed from anonymous to Sewar
  • Priority changed from high to normal
  • Status changed from new to assigned
  • Type changed from defect to enhancement
  • Version changed from 2.0.1 to 2.1

#4 @Sewar
18 years ago

  • Keywords bg|commit added; 2nd-opinion removed

#5 @Nazgul
18 years ago

  • Keywords has-patch commit added; bg|has-patch bg|commit removed

wp-db-backup is no longer part of trunk, but akismet is still valid.

@Sewar
18 years ago

#6 @matt
17 years ago

  • Milestone changed from 2.1 to 2.2

@Sewar
17 years ago

#7 @Sewar
17 years ago

  • Milestone changed from 2.2 to 2.1

matt: Why not doing this in 2.1?

#8 @nbachiyski
17 years ago

If you do want to commit it, please do it sooner, for some translators may be not aware of the procedure of translating plugins, generating different mo files, putting them in the right place and so on. Leave us some time before launch to sort that kind of troubles :)

#9 @ryan
17 years ago

If we commit this, I'll probably add some code that will default the text domain to default if the requested text domain doesn't have a corresponding mo. That way translators can continue using the combined catalog for now.

#10 @nbachiyski
17 years ago

That way we will have to hack the pot generation routine also, because if this was committed the current xgettext script will remove akismet's strings from the pot. Anyway it will not be hard to combine them :)

#11 @jhodgdon
17 years ago

Will someone also update the Codex pages on Internationalization?

#12 @nbachiyski
17 years ago

Yes - we are on some updates.
However, it could also be you ;)

#13 @ryan
17 years ago

  • Milestone changed from 2.1 to 2.1.1

I'm lame and didn't get around to this. Let's postpone to avoid last minute i18n changes.

#14 @foolswisdom
17 years ago

  • Milestone changed from 2.1.1 to 2.2

#15 @Sewar
17 years ago

  • Cc Sewar added
  • Component changed from Administration to i18n
  • Version 2.1 deleted

If you think this will not be fixed, close it as WONTFIX, better than changing milestone all the time.

#16 @rob1n
17 years ago

  • Milestone changed from 2.2 to 2.3

#17 follow-up: @rob1n
17 years ago

For Akismet, why not submit it to the WP plugins Trac? Also, WP-DB-Backup isn't shipped anymore.

#18 @rob1n
17 years ago

  • Milestone 2.3 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

#19 @filosofo
17 years ago

Just in case anyone wonders, although WP-DB-Backup isn't bundled with WP anymore, I'm still maintaining it here (with i18n).

#20 in reply to: ↑ 17 @foolswisdom
17 years ago

Replying to rob1n:

For Akismet, why not submit it to the WP plugins Trac? Also, WP-DB-Backup isn't shipped anymore.

Why was the recent widgets work recorded in the WP plugins trac?

Although, others also favor that, I think this approach breaks down. Anything shipped with WordPress, should have development supported at a single location. Its bugs should stare back at us every day until we fix them, not be in the closet ;-)

Note: See TracTickets for help on using tickets.