Ticket #2582 (closed defect: fixed)

Opened 2 years ago

Last modified 3 months ago

Full text feed problem when using <!--more--> tag

Reported by: tinyau Assigned to: davidhouse
Priority: normal Milestone: 2.5
Component: General Version: 2.1
Severity: major Keywords: ryan
Cc:

Description

In the current revision 3645, the text after <!--more--> tag will not be shown in feed even 'Full text' feed option is selected in admin panel.

Attachments

2582-remove-option-warning.diff (0.8 kB) - added by lloydbudd on 02/09/08 17:48:09.
Need to remove paragraph warning on Reading Settings

Change History

03/20/06 20:29:12 changed by davidhouse

  • owner changed from anonymous to davidhouse.
  • status changed from new to assigned.

03/20/06 21:42:42 changed by davidhouse

<MarkJaquith?> I think that's intended, but I'm not sure <MarkJaquith?> <!--more--> might imply that you want them to go to the permalink to read the thing <MarkJaquith?> the feed just shows what would show on the front page of your site <MarkJaquith?> That seems like good behavior to me <davidhouse> true <davidhouse> we don't show stuff after more even with Full Text

03/20/06 21:43:21 changed by markjaquith

This is intended behavior. By putting <!--more--> you're saying that you want people to view the permalink to see the whole article. In this case, what is shown on your feed and on the front page is the same.

03/20/06 21:43:22 changed by davidhouse

  • status changed from assigned to closed.
  • resolution set to invalid.

Eurgh. Trac.

<MarkJaquith> I think that's intended, but I'm not sure
<MarkJaquith> <!--more--> might imply that you want them to go to the permalink to read the thing
<MarkJaquith> the feed just shows what would show on the front page of your site
<MarkJaquith> That seems like good behavior to me
<davidhouse> true
<davidhouse> we don't show stuff after more even with Full Text

03/20/06 22:09:28 changed by masquerade

  • status changed from closed to reopened.
  • resolution deleted.

If this is the case, we should remove anything after <!--more--> for the description also.

03/20/06 22:12:13 changed by masquerade

Also (sorry for the mail spam wp-trac subscribers), an empty link like <a href="http://localhost/trunk/?p=55#more-55"></a> shouldn't be left in the encoded field either, and perhaps the option name should be changed to disambiguate so that someone else doesn't report this as a bug.

03/20/06 23:50:16 changed by tinyau

Then the intended behavior is different from WordPress 1.5.2? In WordPress 1.5.2, the text after <!--more--> tag is still shown in full text feed.

03/28/06 06:11:15 changed by tinyau

No comment on different behavior between WordPress 1.5.2 and 2.1-alpha?

03/28/06 06:50:37 changed by markjaquith

Cutting off at <!--more--> makes sense to me, but maybe it should be an option, like (excerpt, everthing before <!--more-->, everything)

If the behavior truly has changed, then it needs clarification

04/14/06 03:00:17 changed by tinyau

No comments from the developers about the different behavior between WordPress 1.5 and WordPress 2 for such a long time?

04/14/06 04:09:10 changed by ryan

I see lots of comments from developers.

We just need to make a policy decision. 1.5 or 2.0 style. At this point, if we change it back to 1.5 style, we'll get bugs saying "2.1 is different than 2.0". So, somebody pick. Flip a coin.

04/14/06 06:12:03 changed by markjaquith

Argument in favor of 2.0 style:

<!--more--> hides stuff from your front page, so that people have to view the entry itself to get the whole thing. Your feed is basically a machine-readable version of your front page... why should it be any different? If you wanted people to read the whole thing without an additional click, why use <!--more--> at all?

Another reason: changing it again will create even more confusion than has been caused by the change in 2.0 ... they'll write limericks about us:

There once was a CMS from Automattic, That had <!--more--> behavior quite erratic. They flipped and they flopped, until Podz's poor head popped And the forums were put to a panic.

04/14/06 08:22:57 changed by matt

Yes, but we do really need a (read more...) link in the full-text feeds, because it can be quite confusing when an entry truncates and there is no visual indication that there's more out there.

04/15/06 06:27:04 changed by tinyau

I don't think the feed is exactly the machine-readable version of front page. Feed is the syndication of the article and I think it should be no relationship between feed and '<!--more-->' tag. I think '<!--more-->' tag is just a way to control the presentation of the articles in the front page. 'Full text' feed should mean to display the whole content of the article and if not, why it was called 'Full text' feed?

@ryan, even 2.1 behavior is reverted back to the way as 1.5. If it is stated clearly in the release notes, it should be no problem.

04/15/06 08:14:36 changed by tinyau

In addition, I have to emphasis that the behavior in WordPress 1.5.x and 2.0.x is the same. It is changed in WordPress 2.1 Alpha.

05/30/06 16:02:04 changed by tinyau

Any progress? Since the behavior of WordPress 1.5.x and 2.0.x is the same, keep it the same in version 2.1 should be the most appropriate approach.

09/14/06 18:36:50 changed by ryan

[4184] adds the more link.

09/21/06 02:37:45 changed by tinyau

Changeset 4184 show the more hyperlink in feed if use <!--more--> tag in the posts. Is it the policy confirmed by all developers? If so it is different from the behavior in 1.5 and 2.0 and needs clarification to the public. I would like to see an option to revert back to the behavior of 1.5 and 2.0.

12/01/06 02:43:26 changed by matt

  • status changed from reopened to closed.
  • resolution set to wontfix.

This is the intended behaviour.

01/25/07 02:41:54 changed by afaik

I have a tendency to write long blog posts, in WordPress 2.0.X I used the <!--more--> tag to shorten my front page but my feed was set to full-text and the full post was displayed. After upgrading to 2.1, I don't get the full post. To sum it up, I agree with tinyau. I've found a way to fix this in the support forums (http://wordpress.org/support/topic/88696) but I'm surprised by the new default behavior.

(follow-up: ↓ 22 ) 01/29/07 22:42:36 changed by rmm5t

There is a lot of discussion around this topic. It's evident that some people feel one way, while other's feel another. Personally, while I understand the reasoning behind the change, breaking backwards compatibility in a minor release (2.0 -> 2.1) is the underlying problem IMO.

I think this deserves to be be made into a config option, especially when plugins start to pop up to change the behavior of a new feature to work like an old feature.

(in reply to: ↑ 21 ) 01/30/07 17:05:38 changed by foolswisdom

Replying to rmm5t:

breaking backwards compatibility in a minor release (2.0 -> 2.1) is the underlying problem IMO.

While I don't like this change in behavior, appealing to the size of the version # increment has never been a compelling argument to me. 2.1 from 2.0 represents a years+ worth a work, and has always been presented as a major release. Use of version number in the industry has never been consistent. If you have some best practice references, I would enjoy seeing them.

01/30/07 18:19:41 changed by ryan

Many people want to be able to hide things below the fold, such as spoilers and NSFW pictures, in their full text feeds.

03/21/07 16:59:01 changed by derjohng

  • status changed from closed to reopened.
  • resolution deleted.

I have 'Full text' feed in version 2.0.X about one year. Why is it removed in version 2.1? I need <!--more--> for page view. And I need 'full text' feed for RSS reader.

03/21/07 17:40:37 changed by foolswisdom

  • status changed from reopened to closed.
  • resolution set to wontfix.
  • milestone deleted.

04/10/07 17:14:06 changed by ComputerGuru

CompleteRSS[1] plugin released during the 2.1 alpha addresses this issue, though I'd love to see it "fixed" in 2.2.

[1]: http://neosmart.net/dl.php?id=2

04/11/07 20:46:25 changed by markjaquith

A lot of people don't like this new behavior. This might be one case where a third option for RSS output is warranted.

04/11/07 20:55:37 changed by zamoose

A lot of people don't like this new behavior. This might be one case where a third option for RSS output is warranted.

I'll drink to that.

02/09/08 00:18:46 changed by ryan

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to 2.5.

Looking back, this was a mistake. By popular demand, we're returning to disregarding the more tag when serving feeds.

02/09/08 00:19:49 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6763]) Show full content, including content after the more tag, for feeds. fixes #2582

02/09/08 17:48:09 changed by lloydbudd

  • attachment 2582-remove-option-warning.diff added.

Need to remove paragraph warning on Reading Settings

02/09/08 17:48:40 changed by lloydbudd

  • keywords set to ryan.
  • status changed from closed to reopened.
  • resolution deleted.

02/09/08 19:36:26 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6771]) Remove warning about more tag cutting off posts in feeds. Props lloydbudd. fixes #2582