Ticket #2806 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Incorrect nonce check

Reported by: westi Assigned to: westi
Priority: normal Milestone:
Component: Security Version: 2.0.2
Severity: normal Keywords: bg|has-patch
Cc:

Description

I've done some greping and analysis on the calls to wp_nonce_url, wp_nonce_field and check_admin_referer in branches/2.0 and found an incorrect nonce check.

When I get the time I'll do this for trunk too :-)

Attachments

2806.diff (461 bytes) - added by westi on 06/08/06 20:35:47.
Patch to fix the nonce check for delete-bookmark
delete_bookmark_no_js_fix.diff (0.5 kB) - added by markjaquith on 06/09/06 00:31:51.
Fix for deleting bookmarks with JS off

Change History

06/08/06 20:35:47 changed by westi

  • attachment 2806.diff added.

Patch to fix the nonce check for delete-bookmark

06/08/06 20:36:14 changed by westi

  • keywords set to bg|has-patch.
  • owner changed from anonymous to westi.
  • status changed from new to assigned.
  • component changed from Administration to Security.

06/09/06 00:29:38 changed by markjaquith

Doesn't fix the issue. There's an action mismatch. It sends "delete" but checks for "Delete"

Note that this is all with JavaScript? off... the regular AJAX deletion works fine. My patch fixes it. I'll also be updating my WordPress 2.0.3 tuneup plugin to fix this.

06/09/06 00:31:51 changed by markjaquith

  • attachment delete_bookmark_no_js_fix.diff added.

Fix for deleting bookmarks with JS off

06/09/06 01:05:55 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [3858]) Delete bookmark nonce fix from westi and markjaquith. fixes #2806

11/30/06 19:41:50 changed by

  • milestone deleted.

Milestone 2.0.4 deleted