'link to page' attachment permalink incorrect, if using a relative WordPress URL starting with '/'

[zjohnjohnz]

[version 2.04]

Under Options -> General, if set the WordPress address URL to a relative path beginning with a slash, (e.g., "/wordpress-2.04"), then "link to page" style attachment URLs are re-written incorrectly.

For example, this is what is inserted into the editor buffer for a link to page attachment:

<a id="p13" rel="attachment" href="wordpress-2.04/2006/09/20/test3/ts4/" title="ts4">ts4</a>

The href is missing the needed leading "/", however. Correct is:

a id="p13" rel="attachment" href="/wordpress-2.04/2006/09/20/test3/ts4/" title="ts4">ts4</a>

Possible Fix:

It appears that the fix is extremely simple: on line 120 of
wp-includes/template-functions-links.php change 'trim' to 'rtrim'.

[foolswisdom]

Attached patch of trunk based on zjohnjohnz well written bug and proposed fix above.

[ryan]

Looks like this is now fixed by using trailingslashit.

[westi]

Replying to ryan:

Looks like this is now fixed by using trailingslashit.

Yes. Fixed in [6095] for #2801