Ticket #3523 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Permalink Options page needs to 'HTML entitise' the displayed htaccess rules in the textarea element.

Reported by: JeremyVisser Assigned to: anonymous
Priority: normal Milestone: 2.0.8
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch
Cc:

Description

In /wp-admin/options-permalink.php, when your .htaccess file isn't writable by the server, WordPress will display a textbox for you to copy-and-paste the permalink rules from.

The rules contain the lines "<IfModule mod_rewrite.c>" and "</IfModule>" which must be encoded with HTML entities if it is to be well-formed XHTML. Encoding with wp_specialchars() does the trick.

Attachments

options-permalink.php.diff (0.6 kB) - added by JeremyVisser on 01/05/07 07:16:56.
Uses wp_specialchars() around the .htaccess rules

Change History

01/05/07 07:16:56 changed by JeremyVisser

  • attachment options-permalink.php.diff added.

Uses wp_specialchars() around the .htaccess rules

01/05/07 09:27:24 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [4681]) Ensure XHTML validity when presenting mod_rewrite rules for copy-paste. Props JeremyVisser?. fixes #3523

01/05/07 09:31:22 changed by markjaquith

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.1 to 2.0.7.

Revisit for 2.0.7

Note: unlike most wp_specialchars() omissions, this one does not appear to have security implications... it's just an issue of XHTML validity.

01/11/07 04:52:24 changed by markjaquith

  • milestone changed from 2.0.7 to 2.0.8.

01/23/07 07:51:20 changed by markjaquith

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [4789]) Ensure XHTML validity when presenting mod_rewrite rules for copy-paste. Props JeremyVisser?. fixes #3523