Change wp-login.php to allow web single sign on tools to work

[anhill]

Due to a limitation in JavaScript, web single sign-on tools (in this case Novell Access Manager) are unable to do a form-fill SSO authentication to WordPress. The reason is that several of the form elements are named and ID'd "submit". JavaScript gets confused, and won't execute the form fill code, which includes a "document.forms[0].submit()" function to enable the transparent login.

This patch is very simple - it changes name="submit" to name="wp-submit" and id="submit" to id="wp-submit" in wp-login.php.

Hopefully I made the problem clear - feel free to let me know if there are any questions!

[anhill]

Patch to wp-login.php changing submit attributes

[westi]

Patch looks good.

Should we give them all unique names instead though?

[anhill]

I think the ones named submit are the only ones that would ever cause a problem - the rest should be fine.

[foolswisdom]

anhill, I think westi is asking if each of those three entries you include in your patch should be given unique names?

[JeremyVisser]

No, because they're the same buttons in separate forms.

[rob1n]

I'm with Jeremy on this one.

[ryan]

(In [4981]) Change wp-login submit names and ids. Props anhill. fixes #3917