Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 5 years ago

#4205 closed defect (bug) (fixed)

tiny_mce_gzip is getting gzip compressed twice

Reported by: welcomb's profile welcomb Owned by:
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch commit
Focuses: Cc:

Description

Some servers like mine enable gzip on all output by setting output_handler to ob_gzhandler in php.ini. However zlib is also installed thus the check for compression in line 87 of tiny_mce_gzip.php both fails. Because function ob_gzhandler does exist and zlib.output.compression directive is not set.

This causes tiny_mce_gzip to be encoded twice, resulting in gibberish output to the browser.

To fix, insert an extra condition ini_get('output_handler') != 'ob_gzhandler' to line 87.

Attachments (1)

tiny_mce_gzip.patch (853 bytes) - added by welcomb 17 years ago.

Download all attachments as: .zip

Change History (7)

#1 @rob1n
17 years ago

  • Keywords has-patch commit added; gzip ob_gzhandler double encode removed

Looks good to me. +1.

#2 @rob1n
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5333]) Don't double encode gzip output if gzip is already set in php.ini. Props
welcomb. fixes #4205

#3 @rob1n
17 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 2.2 consideration.

#4 @Nazgul
17 years ago

+1 for getting this into 2.2.

#5 @rob1n
17 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5372]) Don't double encode gzip output if gzip is already set in php.ini. Props welcomb. fixes #4205 for 2.2

This ticket was mentioned in Slack in #core-privacy by webdevlaw. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.