Ticket #4265 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Update included prototype.js to 1.5.1

Reported by: zamoose Assigned to: rob1n
Priority: normal Milestone: 2.3
Component: General Version:
Severity: normal Keywords: javascript js prototype has-patch commit
Cc:

Description

source:trunk/wp-includes/js/prototype.js is sitting at version 1.5. I'd like to propose we bump that to 1.5.1, the latest as per Prototype's site.

Attachments

4265.diff (65.2 kB) - added by rob1n on 05/14/07 20:29:22.
4265-p-s.diff (98.4 kB) - added by zamoose on 05/15/07 14:25:49.
4265-final.diff (97.5 kB) - added by rob1n on 05/16/07 03:10:47.

Change History

(follow-up: ↓ 7 ) 05/14/07 19:40:07 changed by matt

I'd rather freeze it and replace anything that still uses it in core with jQuery.

05/14/07 19:43:07 changed by zamoose

I thought the idea was to make it available for plugin authors (not just for core admin stuff). The changes are pretty significant and unless we're planning on stripping it out, I don't see the logic in not updating...

Full changelog here, with a basic rundown in the improvements being:

*Incredible Selector speedup and full CSS3 support. *Full JSON encoding and decoding support and options for improved security. *Optimized Element#get/setStyle for cross-browser compatibility and speed. *Various String method enhancements and fixes. *The new Form#request method simplifies the common case of submitting a serialized form with XMLHttpRequest. *Many form serialization fixes—if you had troubles before, now they’ve been squashed.

(Cribbed from the Prototype blog.

05/14/07 19:44:02 changed by zamoose

Freakin' WikiFormatting. That should've read:

* Incredible Selector speedup and full CSS3 support. * Full JSON encoding and decoding support and options for improved security. * Optimized Element#get/setStyle for cross-browser compatibility and speed. * Various String method enhancements and fixes. * The new Form#request method simplifies the common case of submitting a serialized form with XMLHttpRequest. * Many form serialization fixes—if you had troubles before, now they’ve been squashed.

05/14/07 19:46:15 changed by filosofo

Ryan had indicated earlier that the plan was to keep Prototype in for plugin and theme authors' benefit. Is the plan now to remove Prototype and Scriptaculous once everything in admin is handled by jQuery?

05/14/07 20:02:34 changed by foolswisdom

Preview ;-) Freakin' WikiFormatting. That should've read:

  • Incredible Selector speedup and full CSS3 support.
  • Full JSON encoding and decoding support and options for improved security.
  • Optimized Element#get/setStyle for cross-browser compatibility and speed.
  • Various String method enhancements and fixes.
  • The new Form#request method simplifies the common case of submitting a serialized form with XMLHttpRequest.
  • Many form serialization fixes—if you had troubles before, now they’ve been squashed.

05/14/07 20:14:21 changed by rob1n

  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.
  • version deleted.

I'm okay with bumping the Prototype. It's backwards compatible and this is one of the pains in the butt that we're going to have to deal with, with maintaining included JS libraries.

(in reply to: ↑ 1 ) 05/14/07 20:15:22 changed by rob1n

Replying to matt:

I'd rather freeze it and replace anything that still uses it in core with jQuery.

I believe Prototype is still there for plugin authors. And it wouldn't hurt to speed up the JS in the core that *does* use Prototype.

05/14/07 20:29:22 changed by rob1n

  • attachment 4265.diff added.

05/14/07 20:30:00 changed by rob1n

  • keywords changed from javascript js prototype to javascript js prototype has-patch commit.

Patch updates Prototype from 1.5.0 to 1.5.1.

05/14/07 20:46:22 changed by ryan

Bump the version in script-loader.php.

Also, update to scriptaculous 1.7.1 beta 2.

Test the hell out of list manipulation and AJAX.

05/14/07 20:57:15 changed by rob1n

Okay.

05/14/07 22:40:45 changed by matt

Good points, okay then.

05/15/07 11:24:03 changed by zamoose

Okay, the diff I just attached should update Script.aculo.us and script-loader.php too. Please test.

05/15/07 11:30:25 changed by zamoose

Rats. Bad TinyMCE bit in that .diff. I'll resubmit.

05/15/07 11:54:27 changed by zamoose

There's also a sound.js included in the Script.aculo.us distro - probably ought to be included and added to script-loader.php. A .diff won't take care of that first part...

05/15/07 13:45:38 changed by rob1n

It will if you svn add it, then svn diff it.

05/15/07 14:25:35 changed by zamoose

Shoot, you're right - I shouldn't post diffs before I have my morning coffee.

Submitting new one now.

05/15/07 14:25:49 changed by zamoose

  • attachment 4265-p-s.diff added.

05/15/07 14:42:58 changed by rob1n

Looks good.

05/15/07 14:43:32 changed by rob1n

Why not just set the version to 1.5.1 instead of 1.5.1-0?

05/15/07 14:53:09 changed by zamoose

rob1n: I was attempting to follow the general style laid out previously. I've no affinity for numbering either way -- I was assuming whomever set the previous version knew what they were doing and thus blindly followed along. *grin*

Why must you persecute we lemmings?

05/15/07 19:12:28 changed by rob1n

I was just wondering :).

I'll probably just take out the -0 when I commit, seems pointless to make + upload another patch just to get rid of that.

I'll commit this later today, after testing list manager and category stuff.

05/15/07 19:32:01 changed by zamoose

Before you commit: looks like I didn't add the sound.js to script-loader.php. Should I add another diff, or do you just want to add it to the end of the scriptaculous-* section when you strip the -0's?

05/15/07 23:20:06 changed by rob1n

I can just do it. No biggie.

05/16/07 03:10:47 changed by rob1n

  • attachment 4265-final.diff added.

05/16/07 03:12:11 changed by rob1n

Tested:

  • Listman (categories, posts, pages)
  • Adding categories in the DBX widget, on-the-fly
  • Autosave
  • Dashboard (AJAX calls)

Everything worked fine. Commit?

05/16/07 03:27:07 changed by rob1n

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5482]) Update Prototype to 1.5.1 and script.aculo.us to 1.7.1-b2. Props zamoose. fixes #4265