in_category() is broken

[markjaquith]

the in_category() function doesn't work correctly in trunk. Likely needs to be re-pointed to use the new term API.

[technosailor]

Fixes in_category to use terms object cache

[technosailor]

Patch attached since it was my conversation with markjaquith that brought this bug up. Appreciate a second set of eyes.

[rob1n]

​http://trac.wordpress.org/changeset/5693 ?

[rob1n]

Ah, but that doesn't use term cache API

[technosailor]

Replying to rob1n:

Ah, but that doesn't use term cache API

I saw Matt's changeset last night after this ticket and patch was submitted.

Which way is better? Mine or his? Mine uses the cache while his does not.

[technosailor]

Rather, mine uses API and his does not. I presume this is what you were saying but I am operating on 1.5h sleep.

[rob1n]

I'm +1 for API. Does your patch need refreshing now that the code's changed?

[technosailor]

I'm using it right now with no problems. Like I mentioned, 'preciate an extra set of eyes to make sure I'm not crazy and the code is solid, but pulling an array value in the way Matt did makes no real sense in the grand scheme of things. The API is so new, though, that I want to make sure I did it right.

[technosailor]

I'll refresh the patch for the latest changeset and resubmit moemntarily.

[technosailor]

Refresh on patch to r5697

[technosailor]

Refreshed. Have a ball. :)

[ryan]

(In [5868]) Update in_category() to use object term cache API. Props technosailor. fixes #4442