Ticket #4442 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

in_category() is broken

Reported by: markjaquith Assigned to: technosailor
Priority: high Milestone: 2.3
Component: Template Version: 2.3
Severity: major Keywords: has-patch
Cc:

Description

the in_category() function doesn't work correctly in trunk. Likely needs to be re-pointed to use the new term API.

Attachments

4442.diff (0.7 kB) - added by technosailor on 06/13/07 01:55:13.
Fixes in_category to use terms object cache
4442.2.diff (0.7 kB) - added by technosailor on 06/13/07 17:23:04.
Refresh on patch to r5697

Change History

06/13/07 01:55:13 changed by technosailor

  • attachment 4442.diff added.

Fixes in_category to use terms object cache

06/13/07 01:56:05 changed by technosailor

  • owner changed from ryan to technosailor.

Patch attached since it was my conversation with markjaquith that brought this bug up. Appreciate a second set of eyes.

06/13/07 16:45:39 changed by rob1n

http://trac.wordpress.org/changeset/5693 ?

(follow-up: ↓ 4 ) 06/13/07 16:45:59 changed by rob1n

Ah, but that doesn't use term cache API

(in reply to: ↑ 3 ) 06/13/07 16:50:01 changed by technosailor

Replying to rob1n:

Ah, but that doesn't use term cache API

I saw Matt's changeset last night after this ticket and patch was submitted.

Which way is better? Mine or his? Mine uses the cache while his does not.

06/13/07 17:00:06 changed by technosailor

Rather, mine uses API and his does not. I presume this is what you were saying but I am operating on 1.5h sleep.

06/13/07 17:09:14 changed by rob1n

I'm +1 for API. Does your patch need refreshing now that the code's changed?

06/13/07 17:11:31 changed by technosailor

I'm using it right now with no problems. Like I mentioned, 'preciate an extra set of eyes to make sure I'm not crazy and the code is solid, but pulling an array value in the way Matt did makes no real sense in the grand scheme of things. The API is so new, though, that I want to make sure I did it right.

06/13/07 17:12:31 changed by technosailor

I'll refresh the patch for the latest changeset and resubmit moemntarily.

06/13/07 17:23:04 changed by technosailor

  • attachment 4442.2.diff added.

Refresh on patch to r5697

06/13/07 17:23:44 changed by technosailor

Refreshed. Have a ball. :)

07/21/07 16:21:56 changed by Nazgul

  • keywords set to has-patch.

08/14/07 03:01:26 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5868]) Update in_category() to use object term cache API. Props technosailor. fixes #4442