$locale var may be set but false

[ashnur]

in wp-includes/l10n.php line nr 5.

if (isset($locale))

should be

if (isset($locale) && $locale)

[Viper007Bond]

Let's not double test. If isset() is in fact not doing the job, let's use something else instead.

​http://www.php.net/manual/en/types.comparisons.php

[ashnur]

Replying to Viper007Bond:

it's not doubletesting, it's testing if it's false. i know that in the wordpress source the format @$locale would be normal, but i, myself like this much cleaner method where first i check if a variable is set, then i check it if it's false. hiding errors .. umm. not even notices it's the way of the lazy programmers. you can't avoid the isset check.

[Nazgul]

I'd go for a if (isset($locale) && !empty($locale)) myself.

[Viper007Bond]

Replying to ashnur:

Replying to Viper007Bond:

it's not doubletesting, it's testing if it's false.

i, myself like this much cleaner method where first i check if a variable is set, then i check it if it's false.

Yes, but again, why test twice when you can just test once?

if ( !empty($locale) ) { ...

Would that not get the job done?

[Nazgul]

Would that not get the job done?

No, because that would throw a warning if the variable is undefined afaik.

[ashnur]

Replying to Nazgul:

I'd go for a if (isset($locale) && !empty($locale)) myself.

see, i dunno if it's ok. i mean, that's exactly what I did, so it should, but maybe i was wrong about it and it has to be if (isset($locale) && $locale !== FALSE )). i doublechecked the source, but got confused. maybe someone else should check it too, and see if I'm right. it's not about religion .. how to check if it's empty or not, it's about a really annoying bug with wordpress MU. the !== false version works for me, but that's just me.

[Viper007Bond]

Replying to Nazgul:

Would that not get the job done?

No, because that would throw a warning if the variable is undefined afaik.

It wouldn't. if ( $var ) does, if ( !empty($var) ) is the exact same thing, but with no warning.

[Viper007Bond]

Oh, and for the record, doing if ( $unsetvar ) { will generate a notice. ;)

[Otto42]

What's the actual bug here? What should it be testing for?

If looks to me like you really want to check if $locale is a string, so would is_string() work?

[Viper007Bond]

Yeah, I guess is a string and not blank aka empty.

[Otto42]

No, the empty string appears to be a valid option here. Because lower down, it explicitly sets $locale to if it's empty, and then applies the same filter.