Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#5103 closed defect (bug) (invalid)

Non localized strings in wp-includes/comment-template.php

Reported by: ranyanivhartstein's profile RanYanivHartstein Owned by: nbachiyski's profile nbachiyski
Milestone: Priority: normal
Severity: normal Version: 2.3
Component: I18N Keywords: has-patch needs-testing 2nd-opinion
Focuses: Cc:

Description

I'm not sure about this patch, I guess if something stayed un-translatable for so long there must be a good reason for it. However I couldn't find any reference to it so here goes.

Several strings in wp-includes/comment-template.php are not localized. This is in lines 210 and 325. I included a patched version of the file, but it should probably be double-checked cause I'm probably missing something here.

Attachments (1)

comment-template.php.diff (997 bytes) - added by RanYanivHartstein 17 years ago.
Fixes non localized strings

Download all attachments as: .zip

Change History (4)

@RanYanivHartstein
17 years ago

Fixes non localized strings

#1 @foolswisdom
17 years ago

  • Milestone set to 2.4
  • Owner changed from anonymous to nbachiyski
  • Version set to 2.3

#2 @nbachiyski
17 years ago

  • Milestone 2.4 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Unfortunately, PHP doesn't allow default argument values to be function calls:

The default value must be a constant expression, not (for example) a variable,
a class member or a function call.

from Function arguments.

Themes should take care of i18n of these strings, themselves, giving i18n-ed factual arguments when calling the function, like this:

comment_type(__('Comment'), __('Trackback'), __('Pingback'));

#3 @RanYanivHartstein
17 years ago

I knew there was a good reason :)

Note: See TracTickets for help on using tickets.