#5103 closed defect (bug) (invalid)
Non localized strings in wp-includes/comment-template.php
Reported by: | RanYanivHartstein | Owned by: | nbachiyski |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.3 |
Component: | I18N | Keywords: | has-patch needs-testing 2nd-opinion |
Focuses: | Cc: |
Description
I'm not sure about this patch, I guess if something stayed un-translatable for so long there must be a good reason for it. However I couldn't find any reference to it so here goes.
Several strings in wp-includes/comment-template.php are not localized. This is in lines 210 and 325. I included a patched version of the file, but it should probably be double-checked cause I'm probably missing something here.
Attachments (1)
Change History (4)
#1
@
17 years ago
- Milestone set to 2.4
- Owner changed from anonymous to nbachiyski
- Version set to 2.3
#2
@
17 years ago
- Milestone 2.4 deleted
- Resolution set to invalid
- Status changed from new to closed
Unfortunately, PHP doesn't allow default argument values to be function calls:
The default value must be a constant expression, not (for example) a variable, a class member or a function call.
from Function arguments.
Themes should take care of i18n of these strings, themselves, giving i18n-ed factual arguments when calling the function, like this:
comment_type(__('Comment'), __('Trackback'), __('Pingback'));
Note: See
TracTickets for help on using
tickets.
Fixes non localized strings