Ticket #5589 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

Import GUID functionality no longer works

Reported by: peterjanes Assigned to: westi
Priority: normal Milestone: 2.5
Component: General Version: 2.3.2
Severity: normal Keywords: reporter-feedback
Cc: peterjanes

Description

WordPress used to preserve GUIDs when importing from RSS feeds. (See Changeset 2193.) Now that the importer uses wp_insert_post that no longer works, since that method always overwrites the GUID with the permalink.

I haven't seen anything that suggests this was a deliberate change, and the RSS and WordPress importers still appear to determine posts' GUIDs so they can be preserved, so I have attached a patch against WP 2.3.2 that changes wp_insert_post to accept and use a guid if provided.

Attachments

wp-import-guid.txt (3.3 kB) - added by peterjanes on 01/07/08 02:58:14.
Patch against trunk

Change History

01/06/08 00:12:55 changed by peterjanes

  • cc set to peterjanes.

01/06/08 06:20:05 changed by lloydbudd

  • keywords set to has-patch.

01/06/08 09:32:03 changed by westi

  • owner changed from anonymous to westi.
  • status changed from new to assigned.

01/06/08 09:36:26 changed by westi

  • keywords changed from has-patch to reporter-feedback.

Thank you for your patch.

However it does not apply correctly to WordPress trunk.

Could you recreate your patch against a clean checkout of trunk and then I will ensure it gets committed.

01/07/08 02:58:14 changed by peterjanes

  • attachment wp-import-guid.txt added.

Patch against trunk

01/07/08 02:59:48 changed by peterjanes

Here's the new patch from current SVN. It also picks up a change to the RSS importer where <guid> without any attributes isn't recognized.

01/10/08 21:27:08 changed by westi

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6593]) Ensure that we preserve GUIDs when importing from RSS. Fixes #5589 props peterjanes.

02/05/08 06:54:49 changed by jeremyclarke

Thanks so much peterjanes and westi! This will be very useful for aggregators!