Ticket #5673 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Plugin activation error_scrape doesnt allways show errors

Reported by: DD32 Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch plugins
Cc:

Description

On some server setups where the Error reporting is set to None, or the display_errors php.ini directive is set to false, Fatal errors are not shown to the user on the plugins page after a failed activation.

Patch attached to enable both. (And ignore E_Notice errors)

Attachments

5673.diff (0.6 kB) - added by DD32 on 01/15/08 11:59:07.
5673.2.diff (1.3 kB) - added by DD32 on 01/16/08 00:20:27.

Change History

01/15/08 11:59:07 changed by DD32

  • attachment 5673.diff added.

(follow-up: ↓ 2 ) 01/15/08 21:32:48 changed by ryan

source:trunk/wp-admin/plugins.php@6580#L46 needs to drop the display_errors check, right?

(in reply to: ↑ 1 ) 01/16/08 00:18:34 changed by DD32

Replying to ryan:

source:trunk/wp-admin/plugins.php@6580#L46 needs to drop the display_errors check, right?

Yep, You're right, I missed that line.

01/16/08 00:20:27 changed by DD32

  • attachment 5673.2.diff added.

01/16/08 00:29:13 changed by DD32

Ticket requires #5658 to be fixed first. Else it redirects and claims that the last plugin on the list had the fault(And then doesnt display the scrape as the nonces dont match).

01/16/08 16:46:49 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6627]) Always show plugin activation errors. Props DD32. fixes #5673