Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#6143 closed defect (bug) (fixed)

Comment action links are not consistently in the same position

Reported by: markjaquith's profile markjaquith Owned by: fergbrain's profile fergbrain
Milestone: 2.5 Priority: normal
Severity: blocker Version: 2.5
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

Green lines were added. These links shouldn't be moving horizontally. We could align-right, or we could move "approve/unapprove" to the slot on the right. I'd suggest the latter.

http://img214.imageshack.us/img214/9550/picture1gs1.png

Attachments (2)

6143.001.diff (1.7 KB) - added by markjaquith 16 years ago.
Move "approve" / "unapprove" to the end
6143.002.diff (3.2 KB) - added by fergbrain 16 years ago.
reapplies changes made with 6143.001.diff

Download all attachments as: .zip

Change History (14)

@markjaquith
16 years ago

Move "approve" / "unapprove" to the end

#1 @markjaquith
16 years ago

  • Keywords has-patch added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

After:

http://img119.imageshack.us/img119/7283/picture2ze8.png

#2 @markjaquith
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7265]) Move "approve/unapprove" links to the right, so the comment action links are consistently in the same position. fixes #6143

#3 @mdawaffe
16 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

+1 - regressed by [7286] though

#4 @markjaquith
16 years ago

Guess Matt didn't see this ticket/commit. Don't know if the order of the buttons is important. If not, I'd suggest Spam, Delete, Approve, Unapprove (and match it by reverting [7286]). If the order is important, we still need to do something to keep the links from moving around, because the whole point was to have these links be in a consistent place so you can rapidly click through. Other options include aligning to the right, or making the links align:block; fixed-width pseudo-button elements.

#5 @westi
16 years ago

  • Severity changed from normal to blocker

+!

They need to be consistent for quick use.

#6 @fergbrain
16 years ago

  • Keywords needs-testing added

Re-applies changes made in 7265 (although based on the latest trunk). Move "approve/unapprove" links to the right, so the comment action links are consistently in the same position.

#7 @fergbrain
16 years ago

  • Owner changed from markjaquith to fergbrain
  • Status changed from reopened to new

#8 @fergbrain
16 years ago

  • Status changed from new to assigned

@fergbrain
16 years ago

reapplies changes made with 6143.001.diff

#9 follow-up: @ryan
16 years ago

Matt said he's down with aligning to the right.

#10 in reply to: ↑ 9 @westi
16 years ago

[7344] fixes this I think.

#11 @fergbrain
16 years ago

[7344] is probably a better fix because it also fixes a similar problem I noticed in on the plugins page.

#12 @markjaquith
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

WFM

Note: See TracTickets for help on using tickets.