Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#6239 closed defect (bug) (fixed)

Mulit-widget widget addition broken with JS turned off.

Reported by: mdawaffe's profile mdawaffe Owned by: mdawaffe's profile mdawaffe
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: widgets has-patch needs-testing
Focuses: Cc:

Description

Another problem caused by our code's lack of differentiation between a type of widget and an instance of that type.

There may not be a perfect fix for this. I'm looking into it.

Attachments (1)

6239.diff (7.9 KB) - added by mdawaffe 16 years ago.

Download all attachments as: .zip

Change History (5)

#1 @mdawaffe
16 years ago

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned
  • Summary changed from Mulitwidget widget addition broken with JS turned off. to Mulit-widget widget addition broken with JS turned off.

With the current code, it is essentially impossible to add a multi-widget instance without going through a POST request.

For non-JS users, the attached patch inserts an intermediate page load between clicking "Add" on a multi-widget and seeing the new instance of that multi-widget showing up in the "Current Widgets" list. This intermediate page lets the user fill out the form fields for that instance of the multi-widget and lets WP process a POST request.

Attached also:

  1. Cleans up a potential PHP warning.
  2. Makes it possible for non-JS users to edit the first widget in the "Current Widgets" list.
  3. Makes it possible for non-JS users to remove widgets from the "Current Widgets" list.
  4. Adds nonce check to widget's "Save Changes" POST request (oops!).

@mdawaffe
16 years ago

#2 @mdawaffe
16 years ago

  • Keywords has-patch needs-testing added

#3 @ryan
16 years ago

(In [7362]) Fix multi-widget addition with JS disabled. Props mdawaffe. see #6239

#4 @mdawaffe
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

No complaints. FIXED.

Note: See TracTickets for help on using tickets.