#6735 closed defect (bug) (fixed)
File upload limit - error message
Reported by: | simonwheatley | Owned by: | |
---|---|---|---|
Milestone: | 2.9 | Priority: | normal |
Severity: | normal | Version: | 2.5 |
Component: | Upload | Keywords: | needs-patch |
Focuses: | Cc: |
Description
To reproduce:
- In php.ini, set post_max_size to something very low (e.g. 1K)
- Restart Apache
- Create a new post, and upload a file of over 1Kb.
- The error message makes mention of upload_max_filesize, but not post_max_size.
The attached patch amends the error message to mention both php.ini values (post_max_size & upload_max_filesize).
There are implications for localisation with this patch, in that it changes a localised string.
Attachments (2)
Change History (13)
#1
@
16 years ago
Examples of this confusing people:
http://wordpress.org/support/topic/165353
#5
@
15 years ago
- Keywords needs-patch added; has-patch needs-testing removed
can't get the patch to apply
#7
@
15 years ago
- Milestone changed from Future Release to 2.9
- Resolution set to fixed
- Status changed from new to closed
I'm pretty sure this was fixed by DD32's patch related to the file upload error messages a few months back.
#8
@
14 years ago
Yes, it was addressed in #10495. But the committed changes make no explicit mention of "php.ini" or either setting. Should it?
#9
@
14 years ago
But the committed changes make no explicit mention of "php.ini" or either setting. Should it?
In my opinion, No. there are 2 sets of people who'll encounter this issue:
- Shared hosting users - They have to contact their host regardless.
- Dedicated setups
- End user using it - Server configuration, contact the sys admin
- Sys admin - Should understand that they need to edit their php.ini file
What i'm saying, Is that, In my opinion, its not worth confusing some users who cant find their php.ini file as they dont have access to it, and instead just refer to it as a server config error.. If a Sys admin comes accross it, They should already know they need to setup PHP correctly.
..And if all else fails, Googling the error will bring up a least 1 support forum thread on it at some point.
Amends upload filesize error to mention all relevant php.ini values