Having many Pages with the same stub causes excess queries

[Viper007Bond]

If you have many Pages with the same stub, many queries can be required to view the Page. This is because it first grabs all Pages with the stub (1 query). Then it loops through each result and queries the details for that result's parent looking for a match.

Instead, why not turn the IDs to search for into a list and grab all of those parents at once? It's a little heavier query, but it's one query rather than tons. Then you can loop through those results checking via PHP.

Thoughts? Am I missing something?

[Viper007Bond]

Otto pointed out on wp-hackers that get_post_ancestors() may do the trick.

[ryan]

We need to walk the parents, not the ancestors.

This untested patch might help a bit. It does one query for the immediate parents, which primes the cache.

[Denis-de-Bernardy]

another alternative would be to walk nothing: when implementing permalink history (another ticket), I'll need to insert post_meta fields. we could then do a direct db check to find a post against a post_meta value.

[scribu]

Sorry for the noob question, but what exactly is a page stub?

[Viper007Bond]

Replying to scribu:

Sorry for the noob question, but what exactly is a page stub?

It's the thing in the URL.

​http://site.com/post-parent/this-is-the-slug/

[johnbillion]

This is being addressed in #16687

[johnbillion]

At least, I think it is. Re-open if not.