Ticket #7684 (reopened defect (bug))

Opened 4 months ago

Last modified 3 months ago

Google Chrome misreported as Safari in Turbo options

Reported by: Mr_Cynical Assigned to: azaozz
Priority: lowest Milestone: 2.9
Component: Administration Version: 2.7
Severity: trivial Keywords:
Cc:

Description

When using the 'Turbo' option in the admin menu under Google Chrome, the browser is misreported as Safari (presumably because it uses the same WebKit? base). It isn't a big deal as everything works fine, it's more of a cosmetic/polish issue caused by the browser sniffer being written before Chrome existed.

Attachments

wp_gears_chrome.jpg (97.9 kB) - added by Mr_Cynical on 09/04/08 09:35:24.
Cropped screenshot of the Turbo/Gears 'ajax popup' that has the fault

Change History

09/04/08 09:35:24 changed by Mr_Cynical

  • attachment wp_gears_chrome.jpg added.

Cropped screenshot of the Turbo/Gears 'ajax popup' that has the fault

09/04/08 18:27:42 changed by ryan

  • owner changed from anonymous to azaozz.

09/05/08 16:29:03 changed by azaozz

  • status changed from new to closed.
  • resolution set to fixed.

(In [8815]) Add simple Chrome detection and updates for Gears dialog, fixes #7684

(follow-up: ↓ 4 ) 09/06/08 00:22:15 changed by caesarsgrunt

  • status changed from closed to reopened.
  • resolution deleted.

I don't really like the language : 

You can disable it from your browser’s Options, Under the Hood menu.

Right-oh. But hang on, where is this Hood menu my browser's options are Under? :)

I'd suggest 

You can disable it from the "Under the Hood" section of your browser's Options.

or even better, 

You can disable it from the "Under the Hood" section of Google Chrome's Options.

since Safari is referred to by name, why not Chrome?

(in reply to: ↑ 3 ; follow-up: ↓ 5 ) 09/06/08 00:34:07 changed by azaozz

Replying to caesarsgrunt:

since Safari is referred to by name, why not Chrome?

Safari has a menu that called... Safari (on Mac) and the menu in Chrome has really no name at all, just an icon.

(in reply to: ↑ 4 ) 09/06/08 19:42:25 changed by caesarsgrunt

Replying to azaozz:

Safari has a menu that called... Safari (on Mac) and the menu in Chrome has really no name at all, just an icon.

Yes, alright. It is actually called the 'Google Chrome Menu', I wasn't referring to the menu. Anyway, I get your point.

How's the first suggestion then?

09/07/08 00:04:41 changed by Speedboxer

Why not just:

Gears is installed and enabled on this computer. You can disable it from Chrome's Tools > Options > Under the Hood dialog.

And yes, it is called the Tools menu (see here).

09/07/08 07:10:30 changed by caesarsgrunt

Not sure about that - whilst is is certainly clear and understandable, it's not technically corect as Under the Hood isn't a dialog, but a tab, or page of a dialog. (Also, should we mention the Gears Settings dialog, which is the next step? Or are we assuming that's obvious?)

And yes, you're right, it's the Tools menu not the Chrome menu. Sorry... (But as said, I wasn't actually referring to the menu.)

(follow-up: ↓ 9 ) 09/07/08 19:07:24 changed by Speedboxer

  • version set to 2.7.
  • milestone set to 2.7.

Yes, but the whole thing is a dialog box. As for mentioning "Change Google Gears Settings", we don't mention anything like that for the other browsers, so I don't think it's necessary here. We could also link to that Google Help Article, which could provide users with more details.

Something like:

Gears is installed and enabled on this computer. You can disable it from Chrome's Tools > Options > Under the Hood dialog. For more details on disabling Gears, please see Google's help article.

(in reply to: ↑ 8 ) 09/07/08 19:48:28 changed by caesarsgrunt

Replying to Speedboxer:

Yes, but the whole thing is a dialog box.

Yes, but "Chrome's Tools > Options > Under the Hood dialog" means that Under the Hood is a dialog, which it isn't. (Actually I'm not sure that Options is even a dialog. Isn't it an options panel? Or is that Mac terminology?)
Maybe I'm being too pedantic, but I do think we should use correct terminology.

I don't think it's really necessary to mention the Tools menu - most people know how to open their browser's Options or can easily work out how.
Also, saying "Tools > Options > Under the Hood" implies nested menus, since that is the syntax normally used for describing menu actions.

How about

Gears is installed and enabled on this computer. You can disable it from the Under the Hood tab in Chrome's Options panel. For more details, please see Google's help page.


As for mentioning "Change Google Gears Settings", we don't mention anything like that for the other browsers, so I don't think it's necessary here.

No, maybe not. Or maybe it should mention it for the other browsers too. But it's probably OK without.

We could also link to that Google Help Article, which could provide users with more details.

Yes, good idea. I have done so in my suggested text, above.

10/14/08 18:20:55 changed by janeforshort

  • milestone changed from 2.7 to 2.9.