WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#8695 closed feature request (fixed)

Send email for approved comments once

Reported by: denis-de-bernardy's profile Denis-de-Bernardy Owned by:
Milestone: 2.8 Priority: normal
Severity: minor Version: 2.7
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Shouldn't this be the default behavior in WP?

​http://wordpress.org/extend/plugins/filter-email-notifications/

Attachments (2)

8695.diff​ (673 bytes) - added by Denis-de-Bernardy 15 years ago.
wp-includes--pluggable.php.diff​ (742 bytes) - added by josephscott 15 years ago.

Download all attachments as: .zip

Change History (12)

#1 @mrmist
15 years ago

  • Milestone changed from 2.7.1 to 2.8
  • Type changed from defect (bug) to feature request

Not really a bug, as the current behaviour could be useful in some cases (I.E. multiple people sharing a login/email.)

Could be added as an option I suppose...

#2 @Denis-de-Bernardy
15 years ago

Honestly, I doubt that sending an email would make sense in the use-case you mention. If I've an editor who uses my account, I probably don't care to receive an email when he approves a comment.

#3 @mrmist
15 years ago

The case I was considering was

  1. Email is sent to say comment is awaiting moderation (this goes to a list or shared mailbox)
  2. Someone logs on to approve said comment.
  3. A further mail is sent out, the other people on that list then know that they don't need to moderate that comment.

I'm not fussed either way. As I said, the idea has potential as an option.

#4 @FFEMTcJ
15 years ago

  • Milestone changed from 2.8 to Future Release

@Denis-de-Bernardy
15 years ago

#5 @Denis-de-Bernardy
15 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 2.8

#6 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11057]) Don't notify post author of own comments. Props Denis-de-Bernardy. fixes #8695

#7 @ryan
15 years ago

(In [11057]) Don't notify post author of own comments. Props Denis-de-Bernardy. fixes #8695

@josephscott
15 years ago

#8 @josephscott
15 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The initial change for this was incorrect. The check should be explicitly for the post author user ID and the comment user ID. I've included a simple patch to make this change.

Currently in the case where the post author is moderating comments the current check always matches because it's looking at the current user.

#9 @Denis-de-Bernardy
15 years ago

very correct.

/me bangs his head on a wall.

#10 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [11387]) Don't notify post author of own comments. PrProps josephscott. fixes #8695

Note: See TracTickets for help on using tickets.